Conversation
spi_protocol.h has included esp_rom_crc.h since c91f956 (CRC-16 frame integrity), but the HLE never got a host version of that header. hle_shims stopped compiling, and the HLE Tests job has failed on every PR since. It runs with continue-on-error, so nobody saw it. Add host versions of esp_rom_crc32_le and esp_rom_crc16_le with the ROM's semantics (the value is inverted on entry and exit, so calls chain), plus the esp_crc.h wrapper that config_sync.c uses. The tests cover the standard check values, chaining, and a seal/validate round trip through spi_protocol.h. Also let the HLE configure on CMake 4. cJSON v1.7.18 still declares cmake_minimum_required(VERSION 3.0), which CMake 4 refuses, so set CMAKE_POLICY_VERSION_MINIMUM around that one FetchContent.
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HLE Tests job has failed on every PR since the CRC-16 framing change in c91f956 (last run).
spi_protocol.hincludesesp_rom_crc.hand the HLE never got a host version of it. The job runs withcontinue-on-error, so it's easy to miss.This adds host versions of
esp_rom_crc32_leandesp_rom_crc16_lewith the ROM's semantics, theesp_crc.hwrapper thatconfig_sync.cuses, and a few tests: the standard check values, chaining, and a seal/validate round trip throughspi_protocol.h. I also compared both functions against IDF's table-driven linux implementation on 60k random buffers, and broke the polynomial on purpose to make sure the check-value test fails.It also sets
CMAKE_POLICY_VERSION_MINIMUMaround the cJSON FetchContent, because cJSON v1.7.18 still declarescmake_minimum_required(VERSION 3.0)and CMake 4 refuses to configure it. With both changeshle_testsis 33/33 locally (CMake 4.4, GCC 16).This only gets
hle_testsbuilding again.hle_interactivehas drifted further than that (new drivers, the app runtime, the vendored fatfs, and the PHY shim doesn't seal CRCs yet), and I'm working on it as a follow-up. Once this job is green, should it dropcontinue-on-error, or is that on purpose?