Skip to content

修复游戏 Java 路径显示滞后问题 - #6419

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
Hylfrd:fix/java-selector-stale-value
Jul 16, 2026
Merged

Glavo merged 1 commit into
HMCL-dev:mainfrom
Hylfrd:fix/java-selector-stale-value

Conversation

@Hylfrd

@Hylfrd Hylfrd commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@Hylfrd
Hylfrd marked this pull request as ready for review July 16, 2026 02:53
Copilot AI review requested due to automatic review settings July 16, 2026 02:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 针对 #6418 中“游戏版本设置的 Java 选择页面右侧路径显示滞后/错乱(显示为上一次选择的 Java)”的问题,通过调整 RadioChoiceList 在切换选项时更新属性的顺序,确保监听 selectedChoice 的外部 UI(如 GameSettingsPage)在回调中读取到的 selectedValue 已经是最新值,从而避免“晚一拍”的显示。

Changes:

  • 在单选切换监听中将 selectedValue 的更新提前到 selectedChoice 之前,以保证外部 selectedChoice 监听回调读取到一致的最新状态。

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo
Glavo merged commit 850a564 into HMCL-dev:main Jul 16, 2026
2 checks passed
Glavo added a commit that referenced this pull request Jul 25, 2026
#6419

Co-authored-by: Apostrophe <Hylfrd@outlook.com>
MinecraftSTL pushed a commit to MinecraftSTL/XYML that referenced this pull request Aug 1, 2026
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/RadioChoiceList.java
@Hylfrd
Hylfrd deleted the fix/java-selector-stale-value branch August 12, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants