Repository navigation
fix(deepseek): map minimal reasoning effort to low - #6132
Merged
chengyongru merged 1 commit intoOct 10, 2026
Merged
Conversation
Collaborator
|
@ZedingZhang could you rebase this PR on the latest main so it can be merged |
ZedingZhang
force-pushed
the
fix/deepseek-minimal-reasoning
branch
from
October 10, 2026 03:58
0c85f92 to
2beaace
Compare
ZedingZhang
force-pushed
the
fix/deepseek-minimal-reasoning
branch
from
October 10, 2026 03:59
2beaace to
7514e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepSeek's Chat Completions requests currently send
reasoning_effort="minimal"together withthinking.type="disabled", even though DeepSeek documentsminimalas an alias for low-effort thinking.Normalize both the semantic and wire effort to
lowin the DeepSeek request builder. This enables thinking consistently and lets the existing history handling backfill missingreasoning_contentfor tool calls. Explicitnonestill disables thinking, and an unspecified effort keeps the provider default.The production change is three lines. Tests cover
minimal,low,none, and the default, plus existing reasoning history and missing tool-call reasoning. The provider registry and other providers' effort mappings are unchanged.Fixes #6122.
Validation on Windows / Python 3.13:
deepseek-flash.python -m pytest tests/providers/test_openai_compat_spec.py tests/providers/test_mistral_provider.py tests/providers/test_xiaomi_mimo_thinking.py -q: 194 passed.python -m pytest tests/providers/test_model_api_presets.py -q -k deepseek: 20 passed.ruff check nanobot tests conftest.py: passed.nanobot/providers/openai_compat_provider.py: 0 errors, 0 warnings.git diff --check: passed.Verification used offline fixtures and isolated local dependencies. No live provider calls were made; the full Python suite and CI dependency/platform matrix were not run locally.