Skip to content

add python snippets and tests for creating, listing, and deleting queues #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmatsuo merged 24 commits into from
Jun 12, 2020
Merged

add python snippets and tests for creating, listing, and deleting queues #4012

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a8cf1d7
add python snippets and tests for creating, listing, and deleting queues
aarjo Jun 8, 2020
7fe9f1c
fix grammar
aarjo Jun 8, 2020
8a9cff9
update licenses
aarjo Jun 8, 2020
7acd2af
Merge branch 'master' into tasks-create-list-delete-queues
averikitsch Jun 8, 2020
4a9a2c1
apply suggested fixes and format with black
aarjo Jun 9, 2020
0693cde
Merge branch 'tasks-create-list-delete-queues' of github.com:aarjo/py…
aarjo Jun 9, 2020
7e5e9ef
Merge branch 'master' into tasks-create-list-delete-queues
aarjo Jun 9, 2020
d8b20d8
Merge branch 'master' of https://github.com/GoogleCloudPlatform/pytho…
aarjo Jun 10, 2020
3018c46
refine delete_queue_test with fixture for setup
aarjo Jun 10, 2020
275fa4a
Merge branch 'master' of https://github.com/GoogleCloudPlatform/pytho…
aarjo Jun 10, 2020
55e3bbf
utilize fixtures and match format of create_http_task_test
aarjo Jun 10, 2020
26e683c
Merge branch 'master' of https://github.com/GoogleCloudPlatform/pytho…
aarjo Jun 10, 2020
145db0c
Merge branch 'tasks-create-list-delete-queues' of github.com:aarjo/py…
aarjo Jun 10, 2020
547ac9d
utilize fixtures in list_queues_test and create_queue_test
aarjo Jun 10, 2020
e4fd742
make create_queue_test call the right function
aarjo Jun 10, 2020
195183f
still attempt to delete queue after test runs in case of failure
aarjo Jun 10, 2020
8552a80
attempt to delete queue in case of failure, using try/except approach
aarjo Jun 10, 2020
eca47d1
add print when NotFound is caught
aarjo Jun 10, 2020
3adeffc
Merge branch 'master' into tasks-create-list-delete-queues
aarjo Jun 12, 2020
eb36f24
Merge branch 'master' into tasks-create-list-delete-queues
Jun 12, 2020
bd4b6a7
fix import
aarjo Jun 12, 2020
fe403ad
Merge branch 'master' of https://github.com/GoogleCloudPlatform/pytho…
aarjo Jun 12, 2020
183e2b6
Merge branch 'tasks-create-list-delete-queues' of github.com:aarjo/py…
aarjo Jun 12, 2020
a76988f
Merge branch 'master' into tasks-create-list-delete-queues
aarjo Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add print when NotFound is caught
  • Loading branch information
@aarjo
aarjo committed Jun 10, 2020
commit eca47d12ccb9f6d3d87609e1683a76fb7e2622af
4 changes: 2 additions & 2 deletions tasks/delete_queue_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def test_queue():
# Attempt to delete the queue in case the sample failed.
client.delete_queue(q.name)
except exceptions.NotFound:
# The queue was successfully deleted, nothing to do.
pass
# The queue was already successfully deleted.
print('Queue already deleted successfully')


def test_delete_queue(capsys, test_queue):
Expand Down