Skip to content

Adds Regression Test By Mocking Input #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waprin merged 6 commits into from
May 22, 2015
Merged

Adds Regression Test By Mocking Input #32

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
357567a
Adds Regression Test By Mocking Input
May 22, 2015
045e6f8
Use context manager to mock raw_input instead of patch
May 22, 2015
032a4c0
Fix unintentional whitespace changes
May 22, 2015
8b24b0b
Change it to list
May 22, 2015
589fbdd
Remove single value use case
May 22, 2015
09961a7
Remove unused import
May 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove single value use case
  • Loading branch information
Bill Prin
Bill Prin committed May 22, 2015
commit 589fbdd7ee671f94f440dbb6db41f9df9d37f1e6
4 changes: 2 additions & 2 deletions bigquery/tests/test_async_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import unittest

from bigquery.samples.async_query import run, main
from tests import CloudBaseTest, mock_raw_input_list, BUCKET_NAME_ENV, \
from tests import CloudBaseTest, mock_raw_input, BUCKET_NAME_ENV, \
PROJECT_ID_ENV

class TestAsyncQuery(CloudBaseTest):
Expand All @@ -37,7 +37,7 @@ def test_async_query_runner(self):
test_project_id = os.environ.get(PROJECT_ID_ENV)
answers = [test_bucket_name, test_project_id, 'n',
'1', '1']
with mock_raw_input_list(answers):
with mock_raw_input(answers):
main()


Expand Down
10 changes: 1 addition & 9 deletions tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
os.path.abspath(os.path.dirname(__file__)), 'resources')


class mock_raw_input_list(object):
class mock_raw_input(object):

def __init__(self, list_):
self.i = 0
Expand All @@ -46,14 +46,6 @@ def __exit__(self, exc_type, exc_value, traceback):
__builtin__.raw_input = self.raw_input_cache


@contextmanager
def mock_raw_input(mock):
original_raw_input = __builtin__.raw_input
__builtin__.raw_input = mock
yield
__builtin__.raw_input = original_raw_input


class CloudBaseTest(unittest.TestCase):

def setUp(self):
Expand Down