Skip to content

Add initial Secret Manager samples #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurtisvg merged 6 commits into from
Dec 30, 2019
Merged

Add initial Secret Manager samples #2664

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
14202be
Add initial Secret Manager samples
sethvargo Dec 27, 2019
688e2bc
Fix quickstart tests
sethvargo Dec 28, 2019
148de1b
Pin to a specific version secretmanager version
sethvargo Dec 28, 2019
0c8aee6
Fix indentation
sethvargo Dec 28, 2019
dbbd2ce
Update copyright header to LLC
sethvargo Dec 28, 2019
286ba29
Remove unused import
sethvargo Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix quickstart tests
  • Loading branch information
@sethvargo
sethvargo committed Dec 30, 2019
commit 688e2bcccc67cfa5a854d8677134d571d3e8eac1
8 changes: 4 additions & 4 deletions secretmanager/api-client/quickstart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import os


def run_quickstart():
def quickstart(_project_id=None, _secret_id=None):
# [START secretmanager_quickstart]
# Import the Secret Manager client library.
from google.cloud import secretmanager_v1beta1 as secretmanager
Expand All @@ -31,8 +31,8 @@ def run_quickstart():
secret_id = 'YOUR_SECRET_ID'

# [END secretmanager_quickstart]
project_id = os.environ['GCLOUD_PROJECT']
secret_id = os.environ['SECRETMANAGER_SECRET_ID']
project_id = _project_id
secret_id = _secret_id
# [START secretmanager_quickstart]
# Create the Secret Manager client.
client = secretmanager.SecretManagerServiceClient()
Expand Down Expand Up @@ -63,4 +63,4 @@ def run_quickstart():


if __name__ == '__main__':
run_quickstart()
quickstart()
21 changes: 0 additions & 21 deletions secretmanager/api-client/quickstart_test.py
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions secretmanager/api-client/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import pytest
import uuid

from quickstart import quickstart
from access_secret_version import access_secret_version
from add_secret_version import add_secret_version
from create_secret import create_secret
Expand Down Expand Up @@ -82,6 +83,11 @@ def secret_version(client, secret):
another_secret_version = secret_version


def test_quickstart(project_id):
secret_id = 'python-secret-{}'.format(uuid.uuid4())
quickstart(project_id, secret_id)


def test_access_secret_version(secret_version):
project_id, secret_id, version_id = secret_version
version = access_secret_version(project_id, secret_id, version_id)
Expand Down