Skip to content

Write a real test for encryption sample code #281

Closed
Closed
Write a real test for encryption sample code#281
Labels
🚨This issue needs some love.testingtriage meI really want to be triaged.

Description

@tmatsuo
tmatsuo
opened on Apr 26, 2016

The current test just invokes the function, but it's very nice if the test actually check if one of the operations described in the doc.

For example, you can invoke:

$ gcloud beta compute disks create example-disk --csek-key-file example-file

with the file created by the current code in the example. When I run the command above with an arbitrary file, it threw the following error:

InvalidKeyFileException: No JSON object could be decoded

IMHO, ensuring it successfully creates a disk by such a test will be a big win.

Activity

  1. tmatsuo
    added
    enhancement
    on Apr 26, 2016
  2. theacodes
    added
    testing
    on May 10, 2016
  3. theacodes
    added a commit that references this issue on May 10, 2016

    Adding test for customer-supplied disk encryption key. Fixes #281

    264a604
  4. theacodes
    closed this as completedin a3d36edon May 11, 2016
  5. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Apr 6, 2020
  6. nicain
    added a commit that references this issue on Nov 2, 2022

    chore(deps): update all dependencies (#281)

    3d2d595
  7. ivanmkc
    added 2 commits that reference this issue on Nov 3, 2022

    chore(deps): update dependency backoff to v2.2.1 (#281)

    b0b710b

    chore(deps): update dependency backoff to v2.2.1 (#281)

    b57e518
  8. msampathkumar
    added 2 commits that reference this issue on Nov 9, 2022

    chore(deps): update all dependencies (#281)

    764c633

    chore(deps): update all dependencies (#281)

    9a993ef
  9. arbrown
    added a commit that references this issue on Nov 14, 2022

    chore(deps): update dependency google-cloud-vision to v2.6.3 (#281)

    2bb258f
  10. dandhlee
    added 2 commits that reference this issue on Nov 15, 2022

    chore(deps): update dependency google-cloud-vision to v2.6.3 (#281)

    0698de2

    chore(deps): update all dependencies (#281)

    4ae3ec2
  11. telpirion
    added a commit that references this issue on Nov 16, 2022

    chore(deps): update dependency google-cloud-translate to v3.6.0 (#281)

    4c1a45b

  12. 8 remaining items

  13. dandhlee
    added a commit that references this issue on Jan 5, 2023

    chore(deps): update all dependencies (#281)

    6586118
  14. telpirion
    added a commit that references this issue on Jan 13, 2023

    chore(deps): update dependency google-cloud-speech to v2.11.1 (#281)

    f0f2b00
  15. rsamborski
    added a commit that references this issue on Jan 20, 2023

    chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281)

    f06041a
  16. gcf-merge-on-green
    added a commit that references this issue on Jan 25, 2023

    migrate code from googleapis/python-security-private-ca (#9028)

    58c69d0
  17. m-strzelczyk
    added a commit that references this issue on Jan 25, 2023

    chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281)

    75e6abf
  18. dandhlee
    added a commit that references this issue on Feb 9, 2023

    chore(deps): update dependency google-cloud-speech to v2.11.1 (#281)

    9b38d3d
  19. telpirion
    added 3 commits that reference this issue on Mar 13, 2023

    migrate code from googleapis/python-security-private-ca (#9028)

    7116d06

    chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281)

    bf83348

    chore(deps): update dependency google-cloud-speech to v2.11.1 (#281)

    187c395
  20. MiaCY
    added a commit that references this issue on Apr 11, 2023

    chore(deps): update dependency pytest to v7.1.3 (#281)

    d3fa282
  21. dandhlee
    added a commit that references this issue on Apr 22, 2023

    chore(deps): update dependency pytest to v7.1.3 (#281)

    7ab92f4
  22. parthea
    added 2 commits that reference this issue on Jun 8, 2023

    chore(deps): update dependency google-api-python-client to v2.77.0 (#281

    d2546a7

    chore(deps): update dependency google-api-python-client to v2.77.0 (#281

    659c294
  23. Linchin
    added a commit that references this issue on Feb 3, 2026

    chore: format code files with nox (#281)

    f851905
  24. iennae
    added a commit that references this issue on Feb 3, 2026

    chore: migrate code from googleapis/python-db-dtypes-pandas (#13776)

    92d6169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🚨This issue needs some love.testingtriage meI really want to be triaged.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions