Skip to content

Uses GitHub Actions for tests and releases. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fdcastel wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Uses GitHub Actions for tests and releases. #61

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ca207a
Add GitHub Actions CI workflow for testing and releases
fdcastel Nov 18, 2025
7a8fc18
Fix DSN construction for remote server connections
fdcastel Nov 18, 2025
e97bd25
Update test configuration to support remote servers with Docker
fdcastel Nov 18, 2025
571bc0a
Update tests to support remote server connections
fdcastel Nov 18, 2025
b39beac
ci: Enable PyPI publishing for official repository builds.
fdcastel Nov 18, 2025
7397e04
ci: Adds `hatch-vcs`.
fdcastel Nov 18, 2025
a0ae985
ci: replace Docker with PSFirebird for unified Windows/Linux testing
fdcastel Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix DSN construction for remote server connections
  • Loading branch information
@fdcastel
fdcastel committed Apr 18, 2026
commit 7a8fc18c476297bc9edd401cf946a43bf08cb165
35 changes: 28 additions & 7 deletions src/firebird/driver/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2164,9 +2164,31 @@ def _connect_helper(dsn: str, host: str, port: str, database: str, protocol: Net
if protocol is not None:
dsn = f'{protocol.name.lower()}://'
if host and port:
dsn += f'{host}:{port}/'
dsn += f'{host}:{port}'
elif host:
dsn += f'{host}/'
dsn += host
# Add database path
# When there's a host, URLs need proper path formatting:
# - Unix absolute paths (start with '/') - need double slash to preserve the leading /
# because Firebird URL parsing strips one /
# - Windows absolute paths (contain ':') - concatenate directly without separator
# - Aliases/relative paths - need '/' separator
# When there's no host (loopback), the path is used as-is
if host:
# For URLs with host
if database.startswith('/'):
# Unix absolute path - use double slash so Firebird keeps the leading /
dsn += f'/{database}' # Results in inet://host//absolute/path
elif ':' in database: # Windows path (e.g., C:\...)
dsn += database # Concatenate directly without separator
else: # Relative/alias
dsn += f'/{database}'
else:
# Loopback - path is used as-is after ://
if database.startswith('/') or ':' in database:
dsn += database
else:
dsn += f'/{database}'
else:
dsn = ''
if host and host.startswith('\\\\'): # Windows Named Pipes
Expand All @@ -2178,7 +2200,7 @@ def _connect_helper(dsn: str, host: str, port: str, database: str, protocol: Net
dsn += f'{host}/{port}:'
elif host:
dsn += f'{host}:'
dsn += database
dsn += database
return dsn

def _is_dsn(value: str) -> bool:
Expand Down Expand Up @@ -2401,10 +2423,9 @@ def create_database(database: str | Path, *, user: str | None=None, password: st
if db_config is None:
db_config = driver_config.db_defaults
srv_config = driver_config.server_defaults
if _is_dsn(database):
dsn = database
database = None
srv_config.host.clear()
dsn = database
database = None
srv_config.host.clear()
else:
database = db_config.database.value
dsn = db_config.dsn.value
Expand Down