Skip to content

Fixed custom CKEditor text replacements - #5364

Open
robinsowell wants to merge 1 commit into
7.devfrom
bugfix/ckeditor-transformation-config-handle
Open

robinsowell wants to merge 1 commit into
7.devfrom
bugfix/ckeditor-transformation-config-handle

Conversation

@robinsowell

Copy link
Copy Markdown
Contributor

Issue

Advanced RTE configuration accepts regular-expression rules for custom CKEditor typing transformations. When ExpressionEngine restores these rules in JavaScript, the generated configuration path omits the active toolset handle.

Problem

The generated script targets EE.Rte.configs.typing instead of the selected toolset configuration. This produces a JavaScript error and leaves the rule as a plain string, so custom text replacements such as smart punctuation do not run.

Fix

  • Scope typing-transformation regular-expression paths to the active RTE toolset.
  • Move regular-expression path generation into a focused helper shared by the existing HTML-support and typing-configuration handling.
  • Add a regression test confirming every generated path includes the toolset handle.

Testing

  • RTE PHPUnit suite: 105 tests, 105 assertions.
  • PHP syntax checks pass for both changed files.
  • Git diff validation passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant