Repository navigation
6.3.1: Fix paging on the node of another connection - #579
Merged
Merged
Conversation
{ movies(first: 2) { edges { node { actors(first: 1) { ... } } } } } with
UseConnectionPaging (or UseOffsetPaging) on the inner field failed with
"unbound variable: p_ConnectionEdge`1", in memory and with EF.
- The inner edges/items field rebuilt its collection from the grandparent
node's NextFieldContext. For `node` that is the schema expression
p_ConnectionEdge.Node, not the edge being selected. Field.GetExpression
now records the context a field with extensions is bound to on the
(per-request) CompileContext, and the edges/items extensions use it.
- The edges field (and its ConnectionEdgeExtension) is shared by every
connection of a type, and its Select parameter was a field on the
extension. The same connection at two levels declared it in nested
lambdas, which EF can not rewrite ("When called from 'VisitLambda'...").
Create it per use.
EF still needs SQL APPLY to page a nested collection inside another paged
nested collection, which SQLite does not support - the two-level case is
tested in memory with a check that no lambda shadows a parameter.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#577 was merged into the #576 branch (
fix/nested-connection-paging-ef) after #576 had merged and 6.3.0 had been released, so its fix never reachedmain. This brings it tomainas 6.3.1.main.CHANGELOG.md: a new 6.3.1 section with the Fix paging on the node of another connection #577 fix. The 6.3.0 section is unchanged frommainand from the published 6.3.0 release notes, neither of which lists Fix paging on the node of another connection #577.PackageVersionbumped to 6.3.1 inEntityGraphQL.csprojandEntityGraphQL.AspNet.csproj.🤖 Generated with Claude Code