Skip to content

Valid GraphQL literals for argument defaults (#562), [Required] args have no default - 6.3.0 #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukemurray merged 4 commits into from
Oct 9, 2026
Merged

Valid GraphQL literals for argument defaults (#562), [Required] args have no default - 6.3.0 #563

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c10059
Print argument defaults as valid GraphQL literals (#562)
lukemurray Sep 29, 2026
c46215c
Treat [Required] arguments like ArgumentHelper.Required<T>(), bump to…
lukemurray Sep 29, 2026
bf9add7
Test default value literals for DateTimeOffset, DateOnly, TimeOnly, T…
lukemurray Sep 29, 2026
309d620
Changelog: list introspection defaultValue quoting under Changes
lukemurray Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test default value literals for DateTimeOffset, DateOnly, TimeOnly, T… 
…imeSpan and char

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
  • Loading branch information
@lukemurray @claude
lukemurray and claude committed Sep 29, 2026
commit bf9add78d8e0463309cab90acd54355e7ba964e6
10 changes: 10 additions & 0 deletions src/tests/EntityGraphQL.Tests/SchemaTests/ToGraphQLSchemaStringTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,16 @@ public void TestGetArgDefaultValue_DateTime()
Assert.Equal("\"2024-01-02T03:04:05\"", SchemaGenerator.GetArgDefaultValue(new DefaultArgValue(true, new DateTime(2024, 1, 2, 3, 4, 5)), (e) => e));
}

[Fact]
public void TestGetArgDefaultValue_StringLikeValueTypes()
{
Assert.Equal("\"2024-01-02T03:04:05+10:00\"", SchemaGenerator.GetArgDefaultValue(new DefaultArgValue(true, new DateTimeOffset(2024, 1, 2, 3, 4, 5, TimeSpan.FromHours(10))), (e) => e));
Assert.Equal("\"2024-01-02\"", SchemaGenerator.GetArgDefaultValue(new DefaultArgValue(true, new DateOnly(2024, 1, 2)), (e) => e));
Assert.Equal("\"03:04:05\"", SchemaGenerator.GetArgDefaultValue(new DefaultArgValue(true, new TimeOnly(3, 4, 5)), (e) => e));
Assert.Equal("\"01:02:03\"", SchemaGenerator.GetArgDefaultValue(new DefaultArgValue(true, new TimeSpan(1, 2, 3)), (e) => e));
Assert.Equal("\"a\"", SchemaGenerator.GetArgDefaultValue(new DefaultArgValue(true, 'a'), (e) => e));
}

[Fact]
public void TestGetArgDefaultValue_String_Escaped()
{
Expand Down
Loading