Repository navigation
Inline Fragments for interfaces (attempt #2) - #134
Merged
lukemurray merged 6 commits intoJul 3, 2022
Merged
Conversation
…ht type and default value on other types
Contributor
Author
|
update: this now gets around the extra property issue by creating multiple types that inherit dynamically at runtime. |
Collaborator
|
Cool. Likely have time to look at this (and others) on the weekend. I was going to suggest dynamic inheritance or creating a weird "union" type. Shall I focus on looking at this one and forget attempt 1? Thanks |
Contributor
Author
|
yeah forget attempt 1, it's simpler but overall don't think it's as good. however there are a couple of hacks in #2 that might need more cleaning up (ParameterReplacer.cs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different attempt to #133
This one uses expression trees to try get around the issue mentioned in other PR
Sadly it doesn't actually get around it because the dynamic type it returns still has all properties (can't use multiple dynamic types as it throws exception about different return types).