Skip to content

Removing Json.net Dependency - #1

Merged
lukemurray merged 2 commits into
EntityGraphQL:masterfrom
leniency:master
Jun 14, 2018
Merged

lukemurray merged 2 commits into
EntityGraphQL:masterfrom
leniency:master

Conversation

@leniency

Copy link
Copy Markdown
Contributor

Changed two things:

  • added a few .gitignore entries from opening in VS2017.
  • Removed Json.net Dependency. It wasn't being used by anything, and was set to v11. This makes running from an Azure Function annoyingly difficult. Azure Functions have some known issues with locked dependencies, Json.Net being one of them (Functions all run directly in the host, which already is locked to Json.Net 9.0.1). Best to just remove the dependency.

leniency added 2 commits June 14, 2018 12:52
…uses conflicts with using in Azure Functions. Those are locked at v9.0.1 by the v1 SDK. This is a known issue there and tied to Azure/azure-functions-host#992
@lukemurray

Copy link
Copy Markdown
Collaborator

Thanks for contributing! Interested to know how you're using this library?

I've actually had had time recently and I was making some changing.

@lukemurray
lukemurray merged commit ccbb724 into EntityGraphQL:master Jun 14, 2018
@leniency

Copy link
Copy Markdown
Contributor Author

I'm doing some initial exploration into GraphQL - just writing up some prototype code and figuring it all out. I really like the idea of using some existing EF models as well as EF's query generation.

@lukemurray

lukemurray commented Jun 14, 2018 •

Copy link
Copy Markdown
Collaborator

Yeh, it is a good starting point I think. But easy to extend or hide fields you don't want in a public api (if that's your target).

I'm actually adding more GraphQL syntax support now. This project started life before that standard was out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants