Skip to content

Only pick a disc sheet the core can read, preferring .cue over .ccd - #1279

Open
jbdemonte wants to merge 1 commit into
EmulatorJS:mainfrom
jbdemonte:fix-disc-sheet-selection
Open

jbdemonte wants to merge 1 commit into
EmulatorJS:mainfrom
jbdemonte:fix-disc-sheet-selection

Conversation

@jbdemonte

Copy link
Copy Markdown

Disc dumps often hold a .ccd next to their .cue. selectRomFile() took the first .cue or .ccd it met as the sheet, then dropped it when the core does not read that extension, without looking for the other one. With Genesis Plus GX, a dump listing its .ccd and .bin before its .cue started the .bin as a cartridge instead of the disc.

A sheet is now only considered when the core supports its extension, and a .cue wins over a .ccd, which wins over .toc and .m3u. The PlayStation preference for .m3u is unchanged.

Disc dumps often hold a .ccd next to their .cue. selectRomFile() took the first .cue or .ccd it met as the sheet, then dropped it when the core does not read that extension, without looking for the other one. With Genesis Plus GX, a dump listing its .ccd and .bin before its .cue started the .bin as a cartridge instead of the disc.

A sheet is now only considered when the core supports its extension, and a .cue wins over a .ccd, which wins over .toc and .m3u. The PlayStation preference for .m3u is unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant