Conversation
joethun
changed the title
ethanaobrien
requested changes
Sep 20, 2026
| } | ||
| getState() { | ||
| return this.Module.EmulatorJSGetState(); | ||
| const info = this.Module.UTF8ToString(this.functions.saveStateInfo()).split("|"); |
Member
There was a problem hiding this comment.
Isn't this the same code that EmulatorJSGetState is lol - if there's a speed issue here that I'm probably missing probably a better idea to upstream it to the RetroArch script then here
| this.startGameError(this.localization("Failed to start game")); | ||
| }); | ||
| } | ||
| withCoreAudioCapture(callback) { |
Member
There was a problem hiding this comment.
Did you attempt building RetroArch with set_volume exposed btw? Iirc this is how we had volume control before OpenAL. I'm not sure how I feel about proxying the audio context
Member
|
Sorry about conflicts |
…le menu button appearing on desktops
Contributor
Author
|
RetroArch repo pull request here |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues #1191 and #1074 and also an issue where the audio controls don't work.