Allow trimming round videos before sending with screen readers - #2165
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
A round video, once recorded, waits above the message field with a strip of its frames, and the part that is sent is cut by dragging the handles at either end of the strip. The strip and its handles are drawn by hand and moved by a finger alone, so a screen reader found nothing there, and a round video could only be sent whole. The start and the end of the part sent are two places now, each read with the time it stands at, and moved a second at a time by swiping up or down, as a slider is, held to the same limits a drag is, through the same calls.
mehranlatifi83
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After recording a round video and stopping it, a timeline with trim handles appears above the input (
VideoTimelineView). It only responds to dragging, so TalkBack users could only send the whole video.Fix
Expose the start and end handles as virtual seek bars that read their time and move one second per swipe, with the same limits and delegate calls as dragging.
Testing
With TalkBack on, record a round video, lock and stop it.
Before: the timeline could not be used. After: start and end handles are read and move by one second.