Skip to content

Allow trimming story video and music with screen readers - #2160

Open
mehranlatifi83 wants to merge 1 commit into
DrKLO:masterfrom
mehranlatifi83:fix/talkback-story-video-trim-unreachable
Open

mehranlatifi83 wants to merge 1 commit into
DrKLO:masterfrom
mehranlatifi83:fix/talkback-story-video-trim-unreachable

Conversation

@mehranlatifi83

@mehranlatifi83 mehranlatifi83 commented Oct 1, 2026 •

Copy link
Copy Markdown

Problem

In the story editor, the video and the added music are trimmed by dragging handles on their timelines (TimelineView). The timelines are drawn and only respond to dragging, so TalkBack finds nothing.

Fix

Expose the start and end handles of the video and of the music as virtual seek bars (ExploreByTouchHelper). Each reads its time, and swiping up or down moves it by one second. They use the same limits as dragging: minimum and maximum length, music within the video, and the other handle following as it does on drag.

Testing

With TalkBack on, create a story from a long video, add music, and swipe to the timelines.

Before: nothing was found. After: four handles are read with their times and move by one second.

A video put in a story is cut to the part that goes out by dragging the
handles at either end of the strip of frames under it. The strip and
its handles are drawn by hand and moved by a finger alone, so a screen
reader found nothing there at all, and a video could only be posted
from its start, cut wherever the longest a story allows ran out.

Music added to a story is cut the same way, by the handles at the ends
of its own strip, and was just as closed.

The start and the end of the part kept, of the video and of the music
alike, are places of their own now, each read with the time it stands
at, and moved a second at a time by swiping up or down, as a slider is.
They are held to the same limits a drag is: never closer than the
shortest part allowed, never further apart than the longest, the music
never outside the video it plays over, and the other end follows where
a drag would move it.
@mehranlatifi83 mehranlatifi83 changed the title Let a screen reader trim the video and the music of a story Allow trimming story video and music with screen readers Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant