Allow trimming story video and music with screen readers - #2160
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
A video put in a story is cut to the part that goes out by dragging the handles at either end of the strip of frames under it. The strip and its handles are drawn by hand and moved by a finger alone, so a screen reader found nothing there at all, and a video could only be posted from its start, cut wherever the longest a story allows ran out. Music added to a story is cut the same way, by the handles at the ends of its own strip, and was just as closed. The start and the end of the part kept, of the video and of the music alike, are places of their own now, each read with the time it stands at, and moved a second at a time by swiping up or down, as a slider is. They are held to the same limits a drag is: never closer than the shortest part allowed, never further apart than the longest, the music never outside the video it plays over, and the other end follows where a drag would move it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the story editor, the video and the added music are trimmed by dragging handles on their timelines (
TimelineView). The timelines are drawn and only respond to dragging, so TalkBack finds nothing.Fix
Expose the start and end handles of the video and of the music as virtual seek bars (
ExploreByTouchHelper). Each reads its time, and swiping up or down moves it by one second. They use the same limits as dragging: minimum and maximum length, music within the video, and the other handle following as it does on drag.Testing
With TalkBack on, create a story from a long video, add music, and swipe to the timelines.
Before: nothing was found. After: four handles are read with their times and move by one second.