Add the chat swipe action as a screen reader action - #2156
Open
mehranlatifi83 wants to merge 1 commit into
Open
mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
A chat in the list is swiped to the left to archive it, or, as chosen in the settings, to mute it, pin it, mark it as read or delete it; in the archive the same swipe takes it out again, and a community is ungrouped by it. A screen reader cannot swipe a row, and the only way left was to hold the chat, find the button in the bar that comes up and press it. Each chat offers what a swipe on it would do as an action of its own, named for it: Archive, Unarchive, Mute or Unmute, Pin to top or Unpin, Mark as read or unread, Delete, Ungroup. It does that through the very same calls the swipe and the bar make, and is not offered where a swipe does nothing.
mehranlatifi83
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Swiping a chat left in the chat list archives it, or, depending on settings, mutes, pins, marks as read, or deletes it; in the archive it unarchives, and in a community it ungroups. TalkBack cannot swipe a row; the only alternative was long press and finding the button in the action bar.
Fix
In
DialogsActivityandDialogCell, add an accessibility action on each chat for what the swipe would do, labeled accordingly (Archive, Unarchive, Mute/Unmute, Pin/Unpin, Mark as read/unread, Delete, Ungroup). It uses the same code as the swipe and is only offered where the swipe does something.Testing
With TalkBack on, open the actions of a chat in the list.
Before: no such action. After: the swipe action from settings is there and works.