Skip to content

correct role handling and S3FS bypass #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErinWeisbart merged 22 commits into from
Jan 21, 2023
Merged

correct role handling and S3FS bypass #130

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0417e7d
correct role handling
ErinWeisbart Jun 16, 2022
526411d
update generate_task_definition
ErinWeisbart Aug 2, 2022
38df4c9
import configparser in run.py
ErinWeisbart Aug 2, 2022
80a8c5b
enable separate source and destination buckets
ErinWeisbart Aug 2, 2022
5498710
oops shouldnt have deleted those
ErinWeisbart Aug 2, 2022
e657f11
fix multibucket handling
ErinWeisbart Aug 3, 2022
cefd9e0
move source destination buckets to config
ErinWeisbart Aug 3, 2022
865d515
switched in and not in
ErinWeisbart Aug 3, 2022
f7919b8
fix s3fs bybass
ErinWeisbart Aug 4, 2022
b9f8916
remove multibucket from job file
ErinWeisbart Aug 4, 2022
3d8cc82
remove changes to run_batch_general
ErinWeisbart Aug 4, 2022
fad0284
csv handling to keep structure
ErinWeisbart Aug 4, 2022
c840b44
pipelines path and run command fixes
ErinWeisbart Aug 5, 2022
8f57047
output, destination, same difference
ErinWeisbart Aug 5, 2022
4ff6463
add upload flags
ErinWeisbart Aug 5, 2022
22abe35
but what if it doesn't exist
ErinWeisbart Aug 5, 2022
e774d41
more things in task definition
ErinWeisbart Aug 5, 2022
7d8f4c8
stash changes
ErinWeisbart Sep 15, 2022
e907c6a
update to AWS CLI2
ErinWeisbart Sep 21, 2022
c66de9e
the right way to check for variable, finally
ErinWeisbart Oct 5, 2022
8cb1390
Merge branch 'master' into role_fix
ErinWeisbart Jan 6, 2023
2b95a36
Update exampleJob.json
ErinWeisbart Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more things in task definition
  • Loading branch information
@ErinWeisbart
ErinWeisbart committed Aug 5, 2022
commit e774d411defed750cd131bb1f37033cdca92f20f
16 changes: 16 additions & 0 deletions run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,22 @@ def generate_task_definition(AWS_PROFILE):
"value": DOWNLOAD_FILES
}
]
if SOURCE_BUCKET:
task_definition['containerDefinitions'][0]['environment'] += [
{
'name': 'SOURCE_BUCKET',
'value': SOURCE_BUCKET
},
{
'name': 'DESTINATION_BUCKET',
'value': DESTINATION_BUCKET
}]
if UPLOAD_FLAGS:
task_definition['containerDefinitions'][0]['environment'] += [
{
'name': 'UPLOAD_FLAGS',
'value': UPLOAD_FLAGS
}]
return task_definition, taskRoleArn

def update_ecs_task_definition(ecs, ECS_TASK_NAME, AWS_PROFILE):
Expand Down