fix(benchmarks): select cached plugin versions numerically - #970
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve cached plugin releases by numeric version components so the agentic benchmark loads the latest installed release. Environment overrides still take precedence; cache selection and activation keep their existing contract.
Reproduction
With both
~/.claude/plugins/cache/ponytail/ponytail/4.9.0and4.10.0installed, the existing lexical ordering chooses 4.9.0. I reproduced this through the publicbenchmarks/agentic/run.pyrunner with one cache task and an offline CLI fixture that records the actual--plugin-dirargument. The fixed runner chooses 4.10.0.The regression check also covers patch versions
4.10.2/4.10.12and preserves an explicit plugin directory override.Scope and prior work
The numeric ordering idea also appeared in #903, which its author closed for a task-scope misunderstanding. This proposal isolates that still-reproducible bug, leaves checkout activation/provenance/rescore metadata out of scope, and does not overlap the active selftest environment restoration in #717 or unused ARM cleanup in #668.
Numeric chunks cover the current release directories; this deliberately does not implement full prerelease SemVer ordering. The code states when a version parser would be needed.
Verification
npm test: 122 passed, zero failures/skips (96 root, 23 Pi, 3 MCP).node scripts/check-rule-copies.js: passed.node scripts/check-versions.js: passed; all eight version files remain 4.10.0.git diff --check: passed.AI-assisted contribution, independently reviewed and replayed before publication.