ruff updates

mscroggs · Apr 1, 2026 · Apr 1, 2026 · Apr 1, 2026 · Apr 1, 2026 · Apr 8, 2026
commit 80881290d4c0eb062351e610351a36cef99d1827
diff --git a/defelement/implementations/__init__.py b/defelement/implementations/__init__.py
@@ -4,14 +4,14 @@
 import os
 from inspect import isclass
 
+from defelement.implementations import jit
 from defelement.implementations.core import (
     DegreeNotImplemented,
     Implementation,
     NotImplementedOnReference,
     VariantNotImplemented,
     parse_example,
 )
-from defelement.implementations import jit
 
 __all__ = [
     "DegreeNotImplemented",

diff --git a/defelement/implementations/jit/__init__.py b/defelement/implementations/jit/__init__.py
@@ -1,4 +1,4 @@
 """Just-in-time compilation."""
 
-from defelement.implementations.jit.argument_types import array, ndarray, integer, double
+from defelement.implementations.jit.argument_types import array, double, integer, ndarray
 from defelement.implementations.jit.cpp import compile as cpp
diff --git a/defelement/implementations/jit/argument_types.py b/defelement/implementations/jit/argument_types.py
@@ -2,6 +2,7 @@
 
 from abc import ABC, abstractmethod
 from itertools import product
+
 import numpy as np
 
 
@@ -253,10 +254,8 @@ def from_raw(self, lib, ffi, obj):
         """Convert raw C object to a Python type."""
         shape = [getattr(obj, f"shape{i}") for i in range(self.dimension)]
         out = np.empty(shape)
-        i = 0
-        for index in product(*[range(j) for j in shape]):
-            out.__setitem__(index, obj.data[i])
-            i += 1
+        for data, index in zip(obj.data, product(*[range(j) for j in shape])):
+            out.__setitem__(index, data)
         return out
 
 

diff --git a/defelement/implementations/jit/cpp.py b/defelement/implementations/jit/cpp.py
@@ -3,30 +3,38 @@
 import os
 import re
 from collections.abc import Callable
-from defelement.implementations.jit import tools
-from defelement.implementations.jit.argument_types import ArgType
-from webtools.tools import join
 
 from cffi import FFI
+from webtools.tools import join
+
+from defelement.implementations.jit import tools
+from defelement.implementations.jit.argument_types import ArgType
 
 here = os.path.dirname(os.path.realpath(__file__))
 
 
 def compile(
     *,
     function: str,
-    inputs: list[ArgType] = [],
-    outputs: list[ArgType] = [],
+    inputs: list[ArgType] | None = None,
+    outputs: list[ArgType] | None = None,
     imports: str | None = None,
     id: str | None = None,
-    packages: list[tuple[str, str]] = [],
+    packages: list[tuple[str, str]] | None = None,
 ) -> Callable:
     """Just-in-time compile a C++ function."""
     folder = tools.source_dir("cpp", id)
 
     library_name = "defelement_function"
     project_name = "DefElementFunction"
 
+    if packages is None:
+        packages = []
+    if inputs is None:
+        inputs = []
+    if outputs is None:
+        outputs = []
+
     true_outputs = [o for o in outputs if not o.in_out]
     in_out = [o for o in outputs if o.in_out]
     function_inputs = ", ".join(f"{i.function_input('cpp')}" for i in inputs + in_out)
@@ -81,9 +89,9 @@ def compile(
                     code += init_i + "\n\n"
             for vars, out in [(inputs + in_out, False), (true_outputs, True)]:
                 for i in vars:
-                    if i.initialise("cpp", output=out) != "":
-                        if f"INIT {i.variable};" not in function:
-                            function = i.initialise("cpp", output=out) + "\n" + function
+                    init_code = i.initialise("cpp", output=out)
+                    if init_code != "" and f"INIT {i.variable};" not in function:
+                        function = init_code + "\n" + function
             if o in in_out:
                 mf = o.metadata_function_signature("cpp", function_inputs_no_in_out)
                 if mf is not None:
@@ -108,7 +116,7 @@ def compile(
                     # TODO: indent
                     code = re.sub(
                         r"( *)INIT " + i.variable,
-                        lambda matches: tools.add_indent(
+                        lambda matches, out=out, i=i: tools.add_indent(
                             i.initialise("cpp", output=out), len(matches[1])
                         ),
                         code,
@@ -149,7 +157,7 @@ def compile(
             assert os.system(f"make -C {folder}/build") == 0
             assert os.system(f"make -C {folder}/build install") == 0
 
-        except BaseException as e:
+        except BaseException as e:  # noqa: BLE001
             tools.save_error(folder, e)
 
     tools.check_for_error(folder)

diff --git a/defelement/implementations/jit/tools.py b/defelement/implementations/jit/tools.py
@@ -1,18 +1,19 @@
 """Utility functions."""
 
-import shutil
-import traceback
-from datetime import datetime
 import hashlib
 import os
+import shutil
+import traceback
+from datetime import datetime, timedelta, timezone
+
 from appdirs import user_cache_dir
 
 try:
     os.mkdir(user_cache_dir())
 except FileExistsError:
     pass
 
-TODAY = datetime.now().strftime("%Y-%m-%d")
+TODAY = datetime.now(tz=timezone(timedelta())).strftime("%Y-%m-%d")
 DIR = user_cache_dir("defelement")
 try:
     os.mkdir(DIR)

diff --git a/defelement/implementations/simplefem.py b/defelement/implementations/simplefem.py
@@ -256,5 +256,5 @@ def verify(
     id = "simplefempp"
     name = "simplefem++"
     url = "https://github.com/DefElement/simplefempp"
-    languages = ["cpp"]
+    languages = ("cpp",)
     verification = True
diff --git a/test/test_jit.py b/test/test_jit.py
@@ -1,4 +1,5 @@
 import numpy as np
+
 from defelement.implementations import jit
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,5 @@
		import numpy as np

		from defelement.implementations import jit


Expand Down