Skip to content

Support agentless log submission for tinylog - #12727

Draft
daniel-mohedano wants to merge 2 commits into
daniel.mohedano/agentless-logs-jboss-logmanagerfrom
daniel.mohedano/agentless-logs-tinylog
Draft

daniel-mohedano wants to merge 2 commits into
daniel.mohedano/agentless-logs-jboss-logmanagerfrom
daniel.mohedano/agentless-logs-tinylog

Conversation

@daniel-mohedano

@daniel-mohedano daniel-mohedano commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Third PR of the agentless log submission stack. It adds tinylog 2.

  • When agentless log submission is enabled, a second advice on TinylogLoggingProvider.output submits each entry once.
    • It runs after the level check, on the producer thread, before the writing thread takes the entry.
  • tinylog only fills the entry values that its writers require, so the advice reads some values itself:
    • the thread name and the thread context, directly
    • the logger name: the class name when writers require it, otherwise the tag
  • The tinylog correlation modules are now context tracking modules, so context injection also works with CI Visibility when tracing is disabled.

Stack:

  1. Logback (Support agentless log submission for Logback #12725)
  2. Shared submission helper and JBoss LogManager (Support agentless log submission for JBoss LogManager #12726)
  3. tinylog 2 (this PR) (Support agentless log submission for tinylog #12727)
  4. Log4j 1 (Support agentless log submission for Log4j 1 #12728)

Motivation

See the first PR of the stack. tinylog already had correlation, but nothing submitted its entries with agentless submission.

Additional Notes

  • Entries without a required class name and without a tag are submitted without loggerName.
  • Nothing changes when agentless log submission is disabled, except the context injection fix above.
  • tinylog is not part of the log injection smoke tests.

Testing:

  • Forked JUnit 5 instrumentation tests on 2.0.0 and latest. They cover:
    • submission with levels, tags, formatted messages and exceptions
    • user context, child spans, no active span
    • two writers (sent once), the writing thread
    • injection disabled, CI Visibility with tracing disabled
  • Muzzle passes.

Jira ticket: SDTEST-3805

@daniel-mohedano daniel-mohedano added type: feature Enhancements and improvements comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM comp: logs Logs Product labels Oct 2, 2026
@daniel-mohedano
daniel-mohedano added this pull request to stack #12729 October 2, 2026 09:20
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 56.64 56.55 $\color{red}{\blacktriangle}$ +0.09 55.43 $\color{red}{\blacktriangle}$ +1.21 116/288
agentEvpProxy 55.88 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@datadog-official

This comment has been minimized.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 37.09 37.15 $\color{green}{\blacktriangledown}$ -0.06 36.42 $\color{red}{\blacktriangle}$ +0.67 69/165
agentless 36.48 36.42 $\color{red}{\blacktriangle}$ +0.06 35.70 $\color{red}{\blacktriangle}$ +0.78 45/137
agentlessCodeCoverage 45.32 45.38 $\color{green}{\blacktriangledown}$ -0.06 44.48 $\color{red}{\blacktriangle}$ +0.84 45/137
agentlessLineCoverage 56.53 56.55 $\color{green}{\blacktriangledown}$ -0.02 56.55 $\color{green}{\blacktriangledown}$ -0.02 43/136

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - pass4s

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 11.37 10.54 $\color{red}{\blacktriangle}$ +0.83 9.73 $\color{red}{\blacktriangle}$ +1.64 69/148
agentless 11.76 9.73 $\color{red}{\blacktriangle}$ +2.03 9.35 $\color{red}{\blacktriangle}$ +2.41 45/120
agentlessCodeCoverage 17.90 17.73 $\color{red}{\blacktriangle}$ +0.17 17.03 $\color{red}{\blacktriangle}$ +0.87 43/113

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 90.69 89.58 $\color{red}{\blacktriangle}$ +1.11 87.80 $\color{red}{\blacktriangle}$ +2.89 69/163
agentless 82.20 82.69 $\color{green}{\blacktriangledown}$ -0.49 81.05 $\color{red}{\blacktriangle}$ +1.15 45/131
agentlessCodeCoverage 97.77 97.04 $\color{red}{\blacktriangle}$ +0.73 97.04 $\color{red}{\blacktriangle}$ +0.73 44/130
agentlessLineCoverage 113.51 113.88 $\color{green}{\blacktriangledown}$ -0.37 111.62 $\color{red}{\blacktriangle}$ +1.89 43/134

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 9.80 9.92 $\color{green}{\blacktriangledown}$ -0.12 9.92 $\color{green}{\blacktriangledown}$ -0.12 43/130

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 21.30 22.09 $\color{green}{\blacktriangledown}$ -0.79 21.65 $\color{green}{\blacktriangledown}$ -0.35 70/170
agentless 17.96 19.20 $\color{green}{\blacktriangledown}$ -1.24 19.20 $\color{green}{\blacktriangledown}$ -1.24 44/132
agentlessCodeCoverage 18.76 19.99 $\color{green}{\blacktriangledown}$ -1.23 19.99 $\color{green}{\blacktriangledown}$ -1.23 44/132
agentlessLineCoverage 25.71 26.98 $\color{green}{\blacktriangledown}$ -1.27 26.98 $\color{green}{\blacktriangledown}$ -1.27 32/82

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from 3e2d8ea to 126265c Compare October 2, 2026 09:43
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 13.15 13.40 $\color{green}{\blacktriangledown}$ -0.25 13.13 $\color{red}{\blacktriangle}$ +0.02 69/169
agentless 12.76 12.12 $\color{red}{\blacktriangle}$ +0.64 11.88 $\color{red}{\blacktriangle}$ +0.88 45/132
agentlessCodeCoverage 15.16 15.41 $\color{green}{\blacktriangledown}$ -0.25 15.11 $\color{red}{\blacktriangle}$ +0.05 45/132
agentlessLineCoverage 16.43 17.03 $\color{green}{\blacktriangledown}$ -0.60 17.38 $\color{green}{\blacktriangledown}$ -0.95 45/133

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@dd-octo-sts

dd-octo-sts Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.04 s 13.92 s [+0.1%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.92 s 13.04 s [-1.7%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.13 s 17.05 s [-0.5%; +1.4%] (no difference)
startup:petclinic:iast:Agent 16.89 s 17.03 s [-1.7%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.52 s 16.84 s [-3.1%; -0.8%] (maybe better)
startup:petclinic:sca:Agent 17.07 s 17.01 s [-0.7%; +1.3%] (no difference)
startup:petclinic:tracing:Agent 16.17 s 16.26 s [-1.5%; +0.3%] (no difference)

Commit: eb384d87 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 94.98 95.12 $\color{green}{\blacktriangledown}$ -0.14 95.12 $\color{green}{\blacktriangledown}$ -0.14 69/168
agentless 91.40 89.58 $\color{red}{\blacktriangle}$ +1.82 89.58 $\color{red}{\blacktriangle}$ +1.82 45/140
agentlessCodeCoverage 100.85 99.00 $\color{red}{\blacktriangle}$ +1.85 99.00 $\color{red}{\blacktriangle}$ +1.85 45/140
agentlessLineCoverage 102.76 101.00 $\color{red}{\blacktriangle}$ +1.76 101.00 $\color{red}{\blacktriangle}$ +1.76 44/144

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 20.97 20.39 $\color{red}{\blacktriangle}$ +0.58 19.99 $\color{red}{\blacktriangle}$ +0.98 69/158
agentless 19.42 19.99 $\color{green}{\blacktriangledown}$ -0.57 19.59 $\color{green}{\blacktriangledown}$ -0.17 48/130
agentlessCodeCoverage 22.98 23.45 $\color{green}{\blacktriangledown}$ -0.47 22.99 $\color{green}{\blacktriangledown}$ -0.01 48/130
agentlessLineCoverage 41.39 39.45 $\color{red}{\blacktriangle}$ +1.94 39.45 $\color{red}{\blacktriangle}$ +1.94 46/129

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 16.22 16.36 $\color{green}{\blacktriangledown}$ -0.14 16.36 $\color{green}{\blacktriangledown}$ -0.14 69/156
agentless 9.77 9.92 $\color{green}{\blacktriangledown}$ -0.15 9.92 $\color{green}{\blacktriangledown}$ -0.15 45/126
agentlessCodeCoverage 13.74 13.67 $\color{red}{\blacktriangle}$ +0.07 13.67 $\color{red}{\blacktriangle}$ +0.07 45/126
agentlessLineCoverage 23.08 22.54 $\color{red}{\blacktriangle}$ +0.54 22.54 $\color{red}{\blacktriangle}$ +0.54 42/125

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 32.97 15.41 $\color{red}{\blacktriangle}$ +17.56 13.40 $\color{red}{\blacktriangle}$ +19.57 69/168
agentless 34.96 12.87 $\color{red}{\blacktriangle}$ +22.09 11.65 $\color{red}{\blacktriangle}$ +23.31 47/140
agentlessCodeCoverage 92.96 89.58 $\color{red}{\blacktriangle}$ +3.38 77.88 $\color{red}{\blacktriangle}$ +15.08 47/140
agentlessLineCoverage 119.02 123.36 $\color{green}{\blacktriangledown}$ -4.34 118.53 $\color{red}{\blacktriangle}$ +0.49 45/140

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from 126265c to eb384d8 Compare October 2, 2026 10:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility comp: logs Logs Product tag: ai generated Largely based on code generated by an AI or LLM type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant