Repository navigation
Fix loss of precision with BigDateTime - #219
lanfeust69 wants to merge 1 commit into
Conversation
We should ensure as much as possible a correct round-trip with DateTime. Since DateTime has a higher precision (1/10 µs instead of 1 µs), this is the limit, but we can avoid truncating microseconds.
|
Hello @zoechelvaraj is this project still maintained ? I see that you accepted this PR a year ago but it's still waiting to be merged |
|
Indeed, I'd like to see this PR merged |
|
I ran this against a live server and it fixes both problems. Setup: ASE 16.0 SP02 PL02 (the
The "before" row is the stock 0.19.2 behavior (the read figure was re-checked today; the write figure is from our earlier run of the same scenario). The decoding error in the read case comes from going through milliseconds and a Related, separate change: #241 adds reading of Found while testing for a release of https://github.com/pengdows/pengdows.crud |
We should ensure as much as possible a correct round-trip with DateTime.
Since DateTime has a higher precision (1/10 µs instead of 1 µs), this is
the limit, but we can avoid truncating microseconds.