WoW Forever: Solo Mode: fix player frame missing when UnitName("player") returns a realm - #271
Open
astronaute77 wants to merge 1 commit into
Open
astronaute77 wants to merge 1 commit into
astronaute77 wants to merge 1 commit into
Conversation
astronaute77
force-pushed
the
fix/solo-player-realm-namelist
branch
from
September 29, 2026 13:18
8a300df to
92c6483
Compare
astronaute77
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
When
UnitName("player")returns a realm, the secure header matchesname-realm, but the nameList held the bare name, so no frame was shown.BuildPartyNameList: player token isname-realmwhen the realm is non-emptyBuildRaidGroupNameListfallback: keep the roster name for the player (same as the cached path)FlatRaidFramessolo branch: same fixTested in game on v5.4.0-alpha.13 (Forever beta): solo frame shows.