Conversation
Forever's spellbook lists each rank as its own spell ID, but bindings stored and cast by name, so "/cast Lesser Heal" always used the highest rank and every rank's cell showed as bound. Ranks below the highest now set pinRank on the binding and cast "Name(Rank N)". Binding the highest rank still casts by name so it keeps upgrading. The spell grid shows rank badges, list rows and binding names show the rank, and bound/duplicate matching is per rank. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On WoW Forever, the spellbook lists each spell rank as its own spell ID (e.g. three Lesser Heal entries), but click-cast bindings store and cast by name only. So
/cast Lesser Healalways uses the highest rank, and every rank's cell in the Binds grid shows as bound.Change
GetAllPlayerSpellsgroups entries that share a name and tags each with its rank (C_Spell.GetSpellSubtext). Every rank below the highest getspinRank.pinRankon the binding, and the macro castsName(Rank N). This covers both the single-binding and combined friendly/hostile macro paths.Retail and flavors without ranks are unaffected: a spell only gets rank handling when several spellbook entries share its name.
Testing
Tested in game on a WoW Forever priest: