feat: ng icons manager v2 - #281

libs/ng-icons-manager/src/internal/cli/watch-coordinator.ts (1)

37-37: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Redundant selected() call.

Line 37 calls this.selected(this.config, selectedJobs) only for early validation and discards the result; apply() (Line 51) validates again. You can drop Line 37 and rely on apply()'s validation, or keep a comment clarifying it is an intentional pre-watch validation gate.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/ng-icons-manager/src/internal/cli/watch-coordinator.ts` at line 37, The
WatchCoordinator flow has a redundant selected() validation call that discards
its result before apply() validates again. Remove the early
this.selected(this.config, selectedJobs) call in watch-coordinator’s setup path,
or if you keep it, add a clear comment that it is an intentional pre-watch
validation gate; use the selected() and apply() methods in WatchCoordinator to
locate the fix.

libs/ng-icons-manager/src/internal/cli/cli-application.ts (1)

26-30: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Redundant jobs() resolution on the non-watch path.

Line 26 resolves+validates the job list and discards it, then once() (Line 39) resolves it again. Consider computing once and passing the resolved jobs down to avoid the double lookup and keep validation in a single place.

♻️ Possible simplification

-      const config = await this.configs.load(configPath);
-      this.jobs(config, options.jobs);
-
-      if (options.verbose) this.logger.info(`Loaded config from ${config.configPath}`);
-      if (options.watch) return this.watch.run(config, options.jobs, options.verbose, signal);
-      return this.once(config, options);
+      const config = await this.configs.load(configPath);
+      const jobs = this.jobs(config, options.jobs);
+
+      if (options.verbose) this.logger.info(`Loaded config from ${config.configPath}`);
+      if (options.watch) return this.watch.run(config, options.jobs, options.verbose, signal);
+      return this.once(jobs, options);

(adjust once() signature accordingly)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/ng-icons-manager/src/internal/cli/cli-application.ts` around lines 26 -
30, The CLI flow in `CLIApplication` resolves `jobs()` twice on the non-watch
path, once before branching and again inside `once()`. Compute the resolved jobs
a single time in `run()` and pass them through to `once()` (and keep
`watch.run()` consistent if needed), then update `once()`’s signature to accept
the already-resolved jobs so validation happens in one place only.

libs/ng-icons-manager/src/internal/infrastructure/native-config-importer.ts (1)

6-9: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value

Cache-busting query string leaks modules across watch reloads.

Appending a unique ?t=${Date.now()} makes the ESM loader treat each reload as a new module and retain it in the registry for the process lifetime. In a long-lived --watch session that reloads config on every change, memory grows unbounded. There's no built-in eviction for the ESM cache, so this is inherent to the approach—worth confirming the watch reload frequency is low enough that this is acceptable, or documenting the tradeoff.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/ng-icons-manager/src/internal/infrastructure/native-config-importer.ts`
around lines 6 - 9, The dynamic import in native-config-importer.importFile uses
a cache-busting query string that causes each watch reload to register a new ESM
module and leak memory over time. Update importFile to avoid unbounded module
growth in long-lived watch sessions by removing or gating the timestamp-based
busting logic, and either reuse stable module URLs or document/confirm the watch
reload tradeoff where importFile is called.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes