Repository navigation
feat: Upgrade to bootstrap 5 - #22
Open
NickJ-7010 wants to merge 7 commits into
Open
NickJ-7010 wants to merge 7 commits into
NickJ-7010 wants to merge 7 commits into
Conversation
…dditional README documentation
Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
what the PR changes
Why
why these changes were made
I wanted to make some improvements to the functionality of plug but getting it running was a struggle as it was not at all setup for local development.
Test Plan
how did you verify these changes did what you expected
A lot of local testing and asking eboard members to sanity check me.
Env Vars
did you add, remove, or rename any environment variables
S3_BUCKET_NAMEto let devs specify the name of their S3 bucket instead of just trying to use the prod one which isplugs.LDAP_WRITE_MODEenv variable to allow for devs to disable the attempted ldap writes and crashing the backend.Documentation
did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.
Made the README.md actually helpful for getting plug setup locally
Checklist