Skip to content
Merged
Prev Previous commit
Next Next commit
fix(chroma): resolve health check 404 and address review feedback
  • Loading branch information
ali-Hamza817 authored and Laurianti committed Oct 7, 2026
commit 3296bf6e507b5ce6a37b0f0a54b8f616da12d080
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Aspire.Chroma/ChromaHealthCheck.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public async Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context
{
try
{
await chromaClient.GetVersion().ConfigureAwait(false);
await chromaClient.Heartbeat().ConfigureAwait(false);

return HealthCheckResult.Healthy();
}
Expand Down
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Aspire.Chroma/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class MyService(ChromaClient chromaClient)
{
public async Task QueryAsync()
{
var version = await chromaClient.GetVersion();
await chromaClient.Heartbeat();
// ...
}
}
Expand Down
10 changes: 10 additions & 0 deletions tests/tmp_inspect/Program.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
using System;
using System.Reflection;
using ChromaDB.Client;

var type = typeof(ChromaClient);
Console.WriteLine($"Methods in {type.FullName}:");
foreach (var method in type.GetMethods(BindingFlags.Public | BindingFlags.Instance))
{
Console.WriteLine($"- {method.Name} (Returns: {method.ReturnType.Name})");
}
10 changes: 10 additions & 0 deletions tests/tmp_inspect_v2/Program.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
using System;
using System.Reflection;
using ChromaDB.Client;

var type = typeof(ChromaClient);
Console.WriteLine($"Methods in {type.FullName}:");
foreach (var method in type.GetMethods(BindingFlags.Public | BindingFlags.Instance))
{
Console.WriteLine($"- {method.Name} (Returns: {method.ReturnType.Name})");
}
11 changes: 11 additions & 0 deletions tests/tmp_inspect_v3/Program.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
using System;
using System.Reflection;
using System.Threading.Tasks;
using ChromaDB.Client;

var type = typeof(ChromaClient);
Console.WriteLine($"Methods in {type.FullName}:");
foreach (var method in type.GetMethods(BindingFlags.Public | BindingFlags.Instance))
{
Console.WriteLine($"- {method.Name} (Returns: {method.ReturnType.Name})");
}
14 changes: 14 additions & 0 deletions tests/tmp_inspect_v3/tmp_inspect_v3.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="ChromaDB.Client" />
</ItemGroup>

</Project>
Binary file added tests/tmp_inspect_v4/Directory.Build.props
Binary file not shown.
Binary file added tests/tmp_inspect_v4/Directory.Packages.props
Binary file not shown.
2 changes: 2 additions & 0 deletions tests/tmp_inspect_v4/Program.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// See https://aka.ms/new-console-template for more information
Console.WriteLine("Hello, World!");
10 changes: 10 additions & 0 deletions tests/tmp_inspect_v4/tmp_inspect_v4.csproj
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

</Project>