This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Repository navigation
Improve JS1 week2 exercise 1 - #14
Merged
Merged
Conversation
* All functions take arguments - artificial examples which don't involve taking input make it less clear to students why functions are useful. * Show expected/actual - this both helps the students debug, and better matches what they should see professionally from tests. * Test that first5 used slice not splice.
ChrisOwen101
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taking input make it less clear to students why functions are useful.
matches what they should see professionally from tests.