Repository navigation
Comparing changes
Open a pull request
base repository: illicitonion/JavaScript-Core-1-Homework
base: master
head repository: CodeYourFuture/JavaScript-Core-1-Homework
compare: master
- 10 commits
- 19 files changed
- 3 contributors
Commits on Jun 20, 2020
-
Improvements to JS1 week1 homework (CodeYourFuture#13)
* Tests show what was expected and what was actually returned. This both helps the students to understand what was wrong, and is more like what they'll encounter in real life from test suites. * Fix up partial rename from getRemainder to getTotal. * Fix up real-world logic of currency conversion (a % fee should _cost_ you more, not _give_ you more!) * Magic 8 ball doesn't use a global variable, and explains slightly more what checkAnswer should actually do. * Magic 8 ball tests to make sure more than one value is actually returned. Note that this introduces use of `require` to import `util` - this is a built-in module in Node, so doesn't add any extra requirements to how the tests are run, but does introduce an element of syntax we haven't taught the students. This is only in the test machinery itself, and is fairly cosmetic, so hopefully won't confuse folks.
Configuration menu - View commit details
-
Copy full SHA for 1ffdd46 - Browse repository at this point
Copy the full SHA 1ffdd46View commit details -
Improve JS1 week2 exercise 1 (CodeYourFuture#14)
* All functions take arguments - artificial examples which don't involve taking input make it less clear to students why functions are useful. * Show expected/actual - this both helps the students debug, and better matches what they should see professionally from tests. * Test that first5 used slice not splice.
Configuration menu - View commit details
-
Copy full SHA for 6e8f73b - Browse repository at this point
Copy the full SHA 6e8f73bView commit details -
Improve JS1 week2 exercise 2 (CodeYourFuture#15)
* Show expected/actual - this both helps the students debug, and better matches what they should see professionally from tests. * Make question about removing element less misleading (its old wording suggests modifying the array, before telling you not to). * Add decimal edge case.
Configuration menu - View commit details
-
Copy full SHA for aebc617 - Browse repository at this point
Copy the full SHA aebc617View commit details
Commits on Jun 21, 2020
-
Improvements to week 3 exercises
* Print expected/actual from tests. * Clarifications in text describing problems. * Add some edge cases: * Oxygen levels - make sure they converted oxygen levels to numbers before comparing. * Journey planner - Don't have all arrays have the same length. * Be more specific about what the credit card validator function should return.Configuration menu - View commit details
-
Copy full SHA for db6281f - Browse repository at this point
Copy the full SHA db6281fView commit details
Commits on Jun 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1630298 - Browse repository at this point
Copy the full SHA 1630298View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10901fd - Browse repository at this point
Copy the full SHA 10901fdView commit details
Commits on Jun 26, 2020
-
Merge pull request CodeYourFuture#40 from illicitonion/week1
Improvements to week1 exercises
Chris Owen authoredJun 26, 2020 Configuration menu - View commit details
-
Copy full SHA for e68af98 - Browse repository at this point
Copy the full SHA e68af98View commit details -
Merge pull request CodeYourFuture#36 from illicitonion/week3
Improvements to week 3 exercises
Chris Owen authoredJun 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 05fe118 - Browse repository at this point
Copy the full SHA 05fe118View commit details
Commits on Jun 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 578cca6 - Browse repository at this point
Copy the full SHA 578cca6View commit details
Commits on Jul 1, 2020
-
Update 7-password-validator.js
Chris Owen authoredJul 1, 2020 Configuration menu - View commit details
-
Copy full SHA for 8d17c19 - Browse repository at this point
Copy the full SHA 8d17c19View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master