Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: carterd888/JavaScript-Core-1-Homework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: CodeYourFuture/JavaScript-Core-1-Homework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 19 files changed
  • 3 contributors

Commits on Jun 20, 2020

  1. Improvements to JS1 week1 homework (CodeYourFuture#13)

    * Tests show what was expected and what was actually returned. This both
      helps the students to understand what was wrong, and is more like what
      they'll encounter in real life from test suites.
    * Fix up partial rename from getRemainder to getTotal.
    * Fix up real-world logic of currency conversion (a % fee should _cost_
      you more, not _give_ you more!)
    * Magic 8 ball doesn't use a global variable, and explains slightly more
      what checkAnswer should actually do.
    * Magic 8 ball tests to make sure more than one value is actually
     returned.
    
    Note that this introduces use of `require` to import `util` - this is a
    built-in module in Node, so doesn't add any extra requirements to how
    the tests are run, but does introduce an element of syntax we haven't
    taught the students. This is only in the test machinery itself, and is
    fairly cosmetic, so hopefully won't confuse folks.
    illicitonion authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    1ffdd46 View commit details
    Browse the repository at this point in the history
  2. Improve JS1 week2 exercise 1 (CodeYourFuture#14)

    * All functions take arguments - artificial examples which don't involve
      taking input make it less clear to students why functions are useful.
    * Show expected/actual - this both helps the students debug, and better
      matches what they should see professionally from tests.
    * Test that first5 used slice not splice.
    illicitonion authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    6e8f73b View commit details
    Browse the repository at this point in the history
  3. Improve JS1 week2 exercise 2 (CodeYourFuture#15)

    * Show expected/actual - this both helps the students debug, and better
      matches what they should see professionally from tests.
    * Make question about removing element less misleading (its old wording
      suggests modifying the array, before telling you not to).
    * Add decimal edge case.
    illicitonion authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    aebc617 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. Improvements to week 3 exercises

    * Print expected/actual from tests.
    * Clarifications in text describing problems.
    * Add some edge cases:
      * Oxygen levels - make sure they converted oxygen levels to numbers
        before comparing.
      * Journey planner - Don't have all arrays have the same length.
    * Be more specific about what the credit card validator function should
      return.
    illicitonion committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    db6281f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    1630298 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10901fd View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Merge pull request CodeYourFuture#40 from illicitonion/week1

    Improvements to week1 exercises
    Chris Owen
    Chris Owen authored Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e68af98 View commit details
    Browse the repository at this point in the history
  2. Merge pull request CodeYourFuture#36 from illicitonion/week3

    Improvements to week 3 exercises
    Chris Owen
    Chris Owen authored Jun 26, 2020
    Configuration menu
    Copy the full SHA
    05fe118 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Moved exercise to week 3

    ChrisOwen101 committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    578cca6 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Update 7-password-validator.js

    Chris Owen
    Chris Owen authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    8d17c19 View commit details
    Browse the repository at this point in the history
Loading