This repository was archived by the owner on Oct 9, 2026. It is now read-only.
Repository navigation
ChromaDotNet.Testcontainers 0.1.7 in the tests, and auto-generated keys only for GUIDs - #16
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new key-validation behavior lacks the required unit regression test.
1 open finding
What changed in this PR
Restricts automatic key generation to Guid keys and updates the Chroma test-container dependency.
Changes:
- Rejects auto-generated non-
Guidkeys during model construction. - Updates ChromaDotNet.Testcontainers from 0.1.3 to 0.1.7.
| File | Description |
|---|---|
src/ChromaDB.VectorData/ChromaModelBuilder.cs |
Adds key-generation validation. |
Directory.Packages.props |
Updates the test-container dependency. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| } | ||
|
|
||
| // String and Guid keys are supported by the Chroma provider, but we support auto-generation of keys only for GUIDs | ||
| if (keyProperty.IsAutoGenerated && keyProperty.Type != typeof(Guid)) |
AnisaHaxhialushi
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, one commit each:
IsAutoGeneratedthrows aNotSupportedExceptionwhen the collection is built. The source of the provider stays the same as in that pull request, but for the namespace.No change of version: main is 0.4.3.
Tested: unit tests, conformance tests against Chroma 1.5.0, 1.5.9 and the latest release, and the NativeAOT application published and run against Chroma 1.5.9.