Repository navigation
Fix node22.18 vs esm compatibility issue - #16712
Merged
Merged
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
melohagan
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some "breaking changes" in node 22.18.0 caused the esm package to fail. We indirectly use this package in
routifier, and because of this, we started having issues last week. The issue started with arm images, and it was patched by pinning the node version: https://github.com/Budibase/budibase-deploys/pull/499From this morning, it is happening in any build. Now, instead of pinning all node versions to 22.17, we can update to the latest version of the fork we use, which was just patched and fixed.