Skip to content

Fix Audit issue 3.6 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eigmax wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Fix Audit issue 3.6 #397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2d2eec4
Fix usage of point types with malformed values
eigmax Sep 21, 2025
52e3e6f
fix chunk_hash_p
Sep 21, 2025
eb733e7
fix q4 should be on curve and in a same subgroup
Sep 21, 2025
38b81c3
point check\ g1/g2 push and read from stack
Sep 21, 2025
ccb316c
replace ark_bn254::G1Affine by NormG1Affine
Sep 22, 2025
b46ae1f
converge all g1/g2 new_unchecks
Sep 22, 2025
bfcb6f6
fix zero push
Sep 22, 2025
8c73725
fix comments and change norm to isomorphic
Sep 24, 2025
a9b8d05
fix p from hash
Sep 24, 2025
ef3c79f
add case: public is zero
Oct 5, 2025
74ec48d
fix chunk hash
Oct 5, 2025
37885e4
change name to FqPair
Oct 5, 2025
7075c78
remove g1 uncheck
Oct 5, 2025
aec1ef6
remove malformed zero
Oct 5, 2025
1329328
add twist point
Oct 6, 2025
470e24c
update prob
Oct 6, 2025
4047d9f
remove ambiguity
Oct 20, 2025
82d62f8
Merge branch 'main' into fix/points
eigmax Oct 22, 2025
66e9e4d
update tests with valid inputs
Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
point check\ g1/g2 push and read from stack
  • Loading branch information
Ubuntu
Ubuntu committed Sep 22, 2025
commit 38b81c3f13e7cb10487bd98c13b64d9376bf2c70
15 changes: 13 additions & 2 deletions bitvm/src/bn254/g1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,16 @@ impl G1Affine {
}
}

pub fn check(element: &ark_bn254::G1Affine) {
assert!(
(element.is_on_curve() && element.is_in_correct_subgroup_assuming_on_curve())
|| (element.x == ark_bn254::Fq::ZERO && element.y == ark_bn254::Fq::ZERO)
|| (element.x == ark_bn254::Fq::ONE && element.y == ark_bn254::Fq::ONE)
)
}

pub fn push(element: ark_bn254::G1Affine) -> Script {
Self::check(&element);
script! {
{ Fq::push_u32_le(&BigUint::from(element.x).to_u32_digits()) }
{ Fq::push_u32_le(&BigUint::from(element.y).to_u32_digits()) }
Expand All @@ -150,11 +159,13 @@ impl G1Affine {
assert_eq!(witness.len() as u32, Fq::N_LIMBS * 2);
let x = Fq::read_u32_le(witness[0..Fq::N_LIMBS as usize].to_vec());
let y = Fq::read_u32_le(witness[Fq::N_LIMBS as usize..2 * Fq::N_LIMBS as usize].to_vec());
ark_bn254::G1Affine {
let element = ark_bn254::G1Affine {
x: BigUint::from_slice(&x).into(),
y: BigUint::from_slice(&y).into(),
infinity: false,
}
};
Self::check(&element);
element
}

pub fn hinted_check_add(t: ark_bn254::G1Affine, q: ark_bn254::G1Affine) -> (Script, Vec<Hint>) {
Expand Down
15 changes: 13 additions & 2 deletions bitvm/src/bn254/g2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,16 @@ impl G2Affine {
(scr, hints)
}

pub fn check(element: &ark_bn254::G2Affine) {
assert!(
(element.is_on_curve() && element.is_in_correct_subgroup_assuming_on_curve())
|| (element.x == ark_bn254::Fq2::ZERO && element.y == ark_bn254::Fq2::ZERO)
|| (element.x == ark_bn254::Fq2::ONE && element.y == ark_bn254::Fq2::ONE)
)
}

pub fn push(element: ark_bn254::G2Affine) -> Script {
Self::check(&element);
script! {
{ Fq2::push(element.x) }
{ Fq2::push(element.y) }
Expand All @@ -122,11 +131,13 @@ impl G2Affine {
let y = Fq2::read_from_stack(
witness[2 * Fq::N_LIMBS as usize..4 * Fq::N_LIMBS as usize].to_vec(),
);
ark_bn254::G2Affine {
let element = ark_bn254::G2Affine {
x,
y,
infinity: false,
}
};
Self::check(&element);
element
}
}

Expand Down
5 changes: 3 additions & 2 deletions bitvm/src/chunk/taps_point_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,7 @@ pub(crate) fn chunk_init_t4(ts: [ark_ff::BigInt<4>; 4]) -> (ElemG2Eval, bool, Sc
ark_bn254::Fq2::new(ts[0].into(), ts[1].into()),
ark_bn254::Fq2::new(ts[2].into(), ts[3].into()),
);
G2Affine::check(&t4.t);
}

let (on_curve_scr, on_curve_hints) = G2Affine::hinted_is_on_curve(t4.t.x, t4.t.y);
Expand Down Expand Up @@ -1110,9 +1111,9 @@ mod test {
ark_ff::BigInt::<4>::one() << 255,
];
let q4 = [
ark_ff::BigInt::<4>::one(),
ark_ff::BigInt::<4>::one(),
ark_ff::BigInt::<4>::zero(),
ark_ff::BigInt::<4>::one(),
ark_ff::BigInt::<4>::zero(),
];

Expand Down Expand Up @@ -1286,7 +1287,7 @@ mod test {

let t3 = t4; // ark_bn254::G2Affine::rand(&mut prng);
let q3 = q4; //ark_bn254::G2Affine::rand(&mut prng);
let p3 = ark_bn254::G1Affine::new_unchecked(-p4.x, -p4.y); //ark_bn254::G1Affine::rand(&mut prng);
let p3 = ark_bn254::G1Affine::new_unchecked(p4.x, -p4.y); //ark_bn254::G1Affine::rand(&mut prng);

let t2 = ark_bn254::G2Affine::rand(&mut prng);
let q2 = ark_bn254::G2Affine::rand(&mut prng);
Expand Down