Skip to content

fix: improve error context in zkVM guest writes and verification #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forkfury wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve error context in zkVM guest writes and verification #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update zkvm.rs
  • Loading branch information
@forkfury
forkfury authored Sep 15, 2025
commit 303ed00782cdfab9f8bb4b22ff7c109a76a1c118
9 changes: 7 additions & 2 deletions final-spv/src/zkvm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,15 @@ impl ZkvmGuest for Risc0Guest {
// use risc0_zkvm::guest::env::Write as _;
let buf = borsh::to_vec(item).expect("Serialization to vec is infallible");
let mut journal = env::journal();
journal.write_all(&buf).unwrap();
journal
.write_all(&buf)
.expect("Failed to write to zkVM journal");
}

fn verify<T: borsh::BorshSerialize>(&self, method_id: [u32; 8], output: &T) {
env::verify(method_id, &borsh::to_vec(output).unwrap()).unwrap();
let encoded_output =
borsh::to_vec(output).expect("Failed to serialize output for verification");
env::verify(method_id, &encoded_output)
.expect("zkVM verification failed: env::verify returned error");
}
}