Skip to content

[Zellic Audit] 3.12 Incomplete handling of G1 point addition #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hakkush-07 merged 5 commits into from
Nov 11, 2025
Merged

[Zellic Audit] 3.12 Incomplete handling of G1 point addition #379

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75ed48d
create a version of G1Affine::hinted_check_add that the caller must u…
Hakkush-07 Sep 11, 2025
d5a1dac
optimize G1Affine::hinted_check_add and add TODO comments for later
Hakkush-07 Sep 19, 2025
4f8cc34
rearrange wrong if checks in G1Affine::hinted_check_add
Hakkush-07 Oct 13, 2025
d6bad4f
add validity checks to hints of new G1Affine::hinted_check_add
Hakkush-07 Oct 13, 2025
1e2f665
fix hint validity check and roll in G1Affine::hinted_check_add
Hakkush-07 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add validity checks to hints of new G1Affine::hinted_check_add
  • Loading branch information
@Hakkush-07
Hakkush-07 committed Oct 13, 2025
commit d6bad4f88438a8386096625e014926bbfbfb095b
6 changes: 3 additions & 3 deletions bitvm/src/bn254/g1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,16 +264,16 @@ impl G1Affine {
OP_FROMALTSTACK OP_DROP
{ G1Affine::drop() }
{ G1Affine::drop() }
{ G1Affine::push_zero() }
{ G1Affine::identity() }
OP_ELSE // case: t != -q
for _ in 0..Fq::N_LIMBS {
OP_DEPTH OP_1SUB OP_ROLL
}
// TODO: uncomment out this line after 3.4 { Fq::copy(0) } { Fq::check_validity() }
{ Fq::copy(0) } { Fq::check_validity() }
for _ in 0..Fq::N_LIMBS {
OP_DEPTH OP_1SUB OP_ROLL
} // qx qy tx ty c3 c4
// TODO: uncomment out this line after 3.4 { Fq::copy(0) } { Fq::check_validity() }
{ Fq::copy(0) } { Fq::check_validity() }
{ Fq::copy(1) } // qx qy tx ty c3 c4 c3
{ Fq::copy(1) } // qx qy tx ty c3 c4 c3 c4
{ Fq::copy(5) } // qx qy tx ty c3 c4 c3 c4 tx
Expand Down
Loading