Skip to content

Clear Part1 Report #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hakkush-07 merged 13 commits into from
Oct 10, 2025
Merged

Clear Part1 Report #300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1c8926f
clear part1 report
Hakkush-07 Jul 17, 2025
0ba4539
add assertion to push_u32_le
Hakkush-07 Jul 17, 2025
bf620a1
fmt
Hakkush-07 Jul 17, 2025
638a26e
remove debug prints and improve test for limb_shr1_carry
Hakkush-07 Aug 21, 2025
e088cb8
fmt
Hakkush-07 Aug 21, 2025
b9ca29a
limb_to_bits functions assert num_bits>0
Hakkush-07 Sep 5, 2025
9e1cdde
change G1Affine::roll, G2Affine::roll, G2Affine::copy parameters to i…
Hakkush-07 Sep 5, 2025
0710290
fmt
Hakkush-07 Sep 5, 2025
d9a9301
assert LIMB_SIZE < 31 in BigIntImpl
Hakkush-07 Sep 29, 2025
7b8e641
restore bigint/mul.rs because it is fixed in another pr
Hakkush-07 Oct 10, 2025
48d2cdf
Merge branch 'main' into part1
Hakkush-07 Oct 10, 2025
3830f7f
fmt
Hakkush-07 Oct 10, 2025
524f399
apply parameter change to double_prevent_overflow_keep_element too
Hakkush-07 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove debug prints and improve test for limb_shr1_carry
  • Loading branch information
@Hakkush-07
Hakkush-07 committed Aug 21, 2025
commit 638a26e40f521accb1748547d41f74d861180049
52 changes: 27 additions & 25 deletions bitvm/src/bigint/inv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,37 +158,39 @@ mod test {

#[test]
fn test_limb_shr1_carry() {
println!("limb_shr1_carry: {} bytes", limb_shr1_carry(29).len());
let mut prng = ChaCha20Rng::seed_from_u64(0);
for shift in 2..30 {
println!("limb_shr1_carry({:?}): {} bytes", shift, limb_shr1_carry(shift).len());
let mut prng = ChaCha20Rng::seed_from_u64(0);

for _ in 0..100 {
let mut a: u32 = prng.gen();
a %= 1 << 29;
for _ in 0..100 {
let mut a: u32 = prng.gen();
a %= 1 << shift;

let script = script! {
{ a }
{ 0 }
{ limb_shr1_carry(29) }
{ a & 1 } OP_EQUALVERIFY
{ a >> 1 } OP_EQUAL
};
let script = script! {
{ a }
{ 0 }
{ limb_shr1_carry(shift) }
{ a & 1 } OP_EQUALVERIFY
{ a >> 1 } OP_EQUAL
};

run(script);
}
run(script);
}

for _ in 0..100 {
let mut a: u32 = prng.gen();
a %= 1 << 29;
for _ in 0..100 {
let mut a: u32 = prng.gen();
a %= 1 << shift;

let script = script! {
{ a }
{ 1 }
{ limb_shr1_carry(29) }
{ a & 1 } OP_EQUALVERIFY
{ (1 << 28) | (a >> 1) } OP_EQUAL
};
let script = script! {
{ a }
{ 1 }
{ limb_shr1_carry(shift) }
{ a & 1 } OP_EQUALVERIFY
{ (1 << (shift - 1)) | (a >> 1) } OP_EQUAL
};

run(script);
run(script);
}
}
}

Expand Down
11 changes: 1 addition & 10 deletions bitvm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,7 @@ fn execute_script_buf_optional_stack_limit(
break;
}
}
for (i, a) in exec.stack().iter_str().enumerate() {
if i % 32 == 31 {
println!(", {:?}", a);
} else if i % 32 == 0 {
print!("stack[{}]: {:?}", i / 32, a);
} else {
print!(", {:?}", a);
}
}
println!("");

let res = exec.result().unwrap();
ExecuteInfo {
success: res.success,
Expand Down