Repository navigation
Fix clippy - #264
Merged
Merged
Fix clippy#264
Conversation
AaronFeickert
approved these changes
Mar 15, 2025
AaronFeickert
left a comment
Contributor
There was a problem hiding this comment.
LGTM, pending a rebase since #257 has been merged.
manishbista28
approved these changes
Mar 15, 2025
Contributor
|
looks good to me, |
Contributor
|
We should update CI to fail on linter warnings (and enforce passing CI for merges). |
Contributor
Author
|
I rebased onto |
Contributor
|
Many more lints from bridge. |
Contributor
Author
|
I reverted the CI change because clippy finds a lot of warnings in the bridge and in other places. Fixing these warnings is out of scope for this PR. |
Open
AaronFeickert
approved these changes
Mar 17, 2025
Contributor
Author
|
Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #259. There are still many warnings outside of
bitvm/bitvm.There were a lot of clippy lints. Especially when running
cargo clippy --all-targets. This PR resolves all of them.I tried to be as conservative as possible, keeping the general function structure the same, not deleting any types, etc. At some places, I allowed the lint instead of resolving it. These lines are searchable via
git grepand can be fixed in follow-up PRs.The manual_div_ceil lint explanation might help reviewers.
There is also the usage of
cfg_chunks_mut!fromark_stdthat caused problems due to the missingparallelfeature. I replaced that line with the non-parallel function call, as by the macro.