Conversation
- Add optional `timeout` parameter to `FirebaseHttpFileService.get` - Forward `headers` and `timeout` to `super.get` - Update `flutter_cache_manager` dependency constraint to `^3.5.0` - Bump version to 2.2.0 and update CHANGELOG.md
3 of 5 tasks
an920107
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature: support the download
timeoutintroduced in #482 inFirebaseHttpFileService.FirebaseHttpFileService.getaccepts onlyheadersand ignores them, so it cannot forward atimeoutto the underlyingHttpFileService.🆕 What is the new behavior (if this is a feature change)?
FirebaseHttpFileService.getnow acceptsDuration? timeoutand forwards bothheadersandtimeouttosuper.get, so Firebase-backed downloads honour the timeout (and custom headers) likeHttpFileServicedoes.Depends on #482 (flutter_cache_manager 3.5.0); the dependency constraint is raised to
^3.5.0.💥 Does this PR introduce a breaking change?
No. The new parameter is optional and behavior is unchanged when
timeoutis not set.🐛 Recommendations for testing
CI runs
flutter analyzeandflutter testfor this package. Note thatflutter pub getneeds flutter_cache_manager 3.5.0 to be published, so CI stays red until #482 is released.📝 Links to relevant issues/docs
Follow-up to #482. Related: #141.
🤔 Checklist before submitting