Fix for #3669 - #3672
Merged
Merged
Fix for #3669#3672
Conversation
Fix for Azure#3669 and addition of AADNonInteractiveUserSignInLogs to the query.
Samik Roy (samikroy)
requested review from
Amit Bergman (Amitbergman),
ms-noamlandress (NoamLandress),
Yaniv Shasha (Yaniv-Shasha),
Yaron (YaronFruchtmann),
Yuval Naor (YuvalNaor),
aprakash13,
Ashwin Patil (ashwin-patil),
SecurityJedi (dicolanl),
Ian Hellen (ianhelle),
juliango2100,
Laith Hisham (laithhisham),
liatlishams,
liemilyg,
Lior Tamir (lior-tamir),
Michael Gladishev (mgladi),
Nan Zang (nazang),
Ofer Shezaf (oshezaf),
Offir Shvartz (oshvartz),
Pete Bryan (petebryan),
Preeti Krishna (preetikr),
sagamzu,
Sarah Young (sarah-yo),
Shain (shainw),
shschwar,
Sreedhar Ande (sreedharande) and
timbMSFT
as code owners
December 10, 2021 06:44
Contributor
Author
|
Javier Soriano (@javiersoriano) - please review here. |
Member
|
Shain (@shainw) Pete Bryan (@petebryan) please check if this the new logic is correct |
Contributor
|
Javier Soriano (@javiersoriano) - I don't think we want to include non-interactive signins in Azure. The AWS login is interactive to the "console". |
Contributor
Author
Shain (@shainw) & Javier Soriano (@javiersoriano) - Updated the query as per the suggestion & review comments. |
Shain (shainw)
approved these changes
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3669 and addition of AADNonInteractiveUserSignInLogs to the query.