Skip to content

feat: Introduce new parse methods for builtin value types. Deprecate XX.parseInt/parseFloat #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGraey merged 13 commits into from
Aug 26, 2022
Merged

feat: Introduce new parse methods for builtin value types. Deprecate XX.parseInt/parseFloat #2465

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8bc2f39
init
MaxGraey Aug 24, 2022
5a88aac
update tests
MaxGraey Aug 24, 2022
e6ad054
add parse method to u8 ... f64 namespaces
MaxGraey Aug 24, 2022
278bbcd
remove I32..F64.parse methods
MaxGraey Aug 24, 2022
7efa20e
use low level strtod instead parseFloat
MaxGraey Aug 25, 2022
b7fd382
add bool.parse
MaxGraey Aug 25, 2022
8d22cb8
better. Add tests
MaxGraey Aug 25, 2022
87b779d
inline
MaxGraey Aug 25, 2022
1687de1
refactor
MaxGraey Aug 25, 2022
f29579b
more stornger bool.parse
MaxGraey Aug 25, 2022
0a7aa48
remove one fast check
MaxGraey Aug 25, 2022
0cd1d33
better
MaxGraey Aug 25, 2022
4b9906f
refactor imports in util/string
MaxGraey Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor
  • Loading branch information
@MaxGraey
MaxGraey committed Aug 25, 2022
commit 1687de166996441893ee08cd19a744c0771ac808
6 changes: 2 additions & 4 deletions std/assembly/util/string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,10 +852,8 @@ export function strtob(str: string): bool {
}
size -= offset;
if (size < 8) return false;
return (
load<u64>(changetype<usize>(str) + offset) ==
0x00_65_00_75_00_72_00_74 // true (as \00\e\00\u\00\e\00\t)
);
// "true" represents as \00\e\00\u\00\e\00\t (00 65 00 75 00 72 00 74)
return load<u64>(changetype<usize>(str) + offset) == 0x0065_0075_0072_0074;
}

export function joinBooleanArray(dataStart: usize, length: i32, separator: string): string {
Expand Down