Skip to content

BREAKING CHANGE: Unify Math & Mathf. Make every method in Math polymorphic #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxGraey wants to merge 14 commits into
base: main
Choose a base branch
from
Open

BREAKING CHANGE: Unify Math & Mathf. Make every method in Math polymorphic #2335

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
abf8b69
refactoring
MaxGraey Jun 24, 2022
7fafa43
lint
MaxGraey Jun 24, 2022
e746365
cleanups
MaxGraey Jun 24, 2022
3bd9eda
defs
MaxGraey Jun 25, 2022
c059065
remove NativeMath#mod but still test it
MaxGraey Jun 25, 2022
562d008
skip ts specialise input types as literals and break flow analysis
MaxGraey Jun 25, 2022
1b66da9
refactor some definitions
MaxGraey Jun 25, 2022
081dd08
Narrow -> Widen
MaxGraey Jun 25, 2022
fa53220
refactor test utils
MaxGraey Jun 25, 2022
94b3e8b
refactor again
MaxGraey Jun 25, 2022
0394a49
remove integer path for Math.log2
MaxGraey Jun 25, 2022
baee9e8
mark as deprecated non-recommended methods
MaxGraey Jun 25, 2022
69a4fca
add compilation warnings for unnecessary integer operations
MaxGraey Jun 25, 2022
771e21a
cleanup
MaxGraey Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mark as deprecated non-recommended methods
  • Loading branch information
@MaxGraey
MaxGraey committed Jun 25, 2022
commit baee9e80e1817b0f8d0a26c590dc18f6a2e0081a
6 changes: 3 additions & 3 deletions std/assembly/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,7 +2066,7 @@ interface IMath {
cbrt<T extends f32 | f64>(x: T): Widen<T>;
/** Returns the smallest integer greater than or equal to `x`. */
ceil<T extends u8 | u16 | u32 | u64 | i8 | i16 | i32 | i64 | f32 | f64>(x: T): Widen<T>;
/** Returns the number of leading zero bits in the 32-bit binary representation of `x`. @deprecate */
/** @deprecated Returns the number of leading zero bits in the 32-bit binary representation of `x`. */
clz32<T extends u8 | u16 | u32 | u64 | i8 | i16 | i32 | i64 | f32 | f64>(x: T): Widen<T>;
/** Returns the cosine (in radians) of `x`. */
cos<T extends f32 | f64>(x: T): Widen<T>;
Expand All @@ -2078,11 +2078,11 @@ interface IMath {
expm1<T extends f32 | f64>(x: T): Widen<T>;
/** Returns the largest integer less than or equal to `x`. */
floor<T extends u8 | u16 | u32 | u64 | i8 | i16 | i32 | i64 | f32 | f64>(x: T): Widen<T>;
/** Returns the nearest 32-bit single precision float representation of `x`. */
/** @deprecated Returns the nearest 32-bit single precision float representation of `x`. */
fround<T extends f32 | f64>(x: T): Widen<T>;
/** Returns the square root of the sum of squares of its arguments. */
hypot<T extends f32 | f64>(a: T, b: T): Widen<T>; // TODO: rest
/** Returns the result of the C-like 32-bit multiplication of `a` and `b`. @deprecate */
/** @deprecated Returns the result of the C-like 32-bit multiplication of `a` and `b`. */
imul<T extends u8 | u16 | u32 | u64 | i8 | i16 | i32 | i64 | f32 | f64>(a: T, b: T): Widen<T>;
/** Returns the natural logarithm (base e) of `x`. */
log<T extends f32 | f64>(x: T): Widen<T>;
Expand Down