fix(i18n): restore interpolation variables in de-DE translations - #9019
Open
owgreen-dev wants to merge 1 commit into
Open
owgreen-dev wants to merge 1 commit into
owgreen-dev wants to merge 1 commit into
Conversation
Three German strings translated the interpolation variable name itself (`{Name}`, `{Zeit}`), so the
value is never substituted and users see the literal token instead of the page name / timestamp.
### What's changed (`frontend/resources/translations/de-DE.json`, +3/−3)
| key | before | after |
|---|---|---|
| `tooltip.referencePage` | `Auf diesen {Name} wird verwiesen` | `Auf diesen {name} wird verwiesen` |
| `web.fileBlock.uploadedAt` | `Hochgeladen am {Zeit}` | `Hochgeladen am {time}` |
| `web.fileBlock.linkedAt` | `Link hinzugefügt am {Zeit}` | `Link hinzugefügt am {time}` |
Variable names now match `en-US.json`; German wording unchanged.
Found while running an open-source placeholder checker I maintain (shipi18n) over a few OSS locale
trees; each change was checked by hand against `en-US.json`. cs-CZ and pl-PL have a related issue
(`{count}` became a bare `{}` in 8 keys) — happy to send that as a separate PR if this one is welcome.
No existing issue for this; translation-only change, no code touched.
#### PR Checklist
- [x] My code adheres to AppFlowy's Conventions
- [x] I've listed at least one issue that this PR fixes in the description above — n/a (no issue exists; translation fix only)
- [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
- [x] All existing tests are passing.
|
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR fixes three German locale placeholders so page names and timestamps are interpolated instead of displayed as literal tokens; no application code or behavior outside these translations is changed. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three German strings translated the interpolation variable name itself (
{Name},{Zeit}), so the value is never substituted and users see the literal token instead of the page name / timestamp.What's changed (
frontend/resources/translations/de-DE.json, 3 strings)tooltip.referencePageAuf diesen {Name} wird verwiesenAuf diesen {name} wird verwiesenweb.fileBlock.uploadedAtHochgeladen am {Zeit}Hochgeladen am {time}web.fileBlock.linkedAtLink hinzugefügt am {Zeit}Link hinzugefügt am {time}Variable names now match
en-US.json; German wording unchanged.Found while running an open-source i18n placeholder checker I maintain (shipi18n) over a few OSS locale trees; each change was checked by hand against
en-US.json. cs-CZ and pl-PL have a related issue ({count}became a bare{}in 8 keys) — happy to send that as a separate PR if this one is welcome.No existing issue for this; translation-only change, no code touched.
PR Checklist
Summary by Sourcery
Bug Fixes: