[OGUI-1924] Fix incorrectly called disableAutoScroll - #3636
Open
isaachilly wants to merge 25 commits into
Open
isaachilly wants to merge 25 commits into
isaachilly wants to merge 25 commits into
Conversation
The table scroll handler treated any decrease in scrollTop as the user scrolling up however this caught also just when the content shrunk which happens on switch from a full query mode to an initially empty live mode. Check now also if at the bottom of the page and if we still are then don't disableAutoScroll.
isaachilly
changed the title
Introduces a suite to cover autoscroll behaviour when users scroll, switch modes, and clear logs in both query and live mode.
Refactor the logs table mocha tests to wait for `autoScrollLive` state transitions with a shared helper instead of reading the value immediately.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Refactor the table autoscroll tests into clearer query/live mode suites and added reusable helpers.
No need to modify the autoScrollLive setting when a user resizes their browser so split the listeners up.
isaachilly
marked this pull request as ready for review
September 28, 2026 15:35
graduta
reviewed
Sep 29, 2026
graduta
left a comment
graduta
left a comment
Member
There was a problem hiding this comment.
Given that auto-scroll should be a feature only for live mode (as it does not make sense for query mode), would the logic not be easier to use that?
For example:
- entering live mode would not have to be decided based on scroll but instead enabled directly
- switching to query mode, should disable autoscroll and not use any scroll events at all
What do you think?
Collaborator
Author
I'm a little confused on what is getting "decided on scroll". If you mean autoscroll then it's already being directly enabled.
I agree the handling of scroll events in query mode is not needed. |
Button style, live icon, browser tab title and auto-scroll were set inside the click handler via module-level state, so any mode change not triggered by a click left the UI stale. Derive them from log.activeMode in the model/view instead.
…into bug/ILG/OGUI-1924/Fix-incorrectly-called-disableAutoScroll
isaachilly
changed the base branch from
dev
to
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
September 29, 2026 16:56
isaachilly
force-pushed
the
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
branch
from
September 30, 2026 15:00
0b54150 to
f62dafb
Compare
…into bug/ILG/OGUI-1924/Fix-incorrectly-called-disableAutoScroll
…into bug/ILG/OGUI-1924/Fix-incorrectly-called-disableAutoScroll
The status bar now shows the autoscroll indicator only while live mode is running and the user cannot disable it. They can only enable it by scrolling to the bottom of the page or by clicking the label text.
Adjust tests to match the current autoscroll behaviour in live mode. The logs table tests now simulate real wheel input and cover re-enabling autoscroll at the bottom and during zoom.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
When clicking live mode after running a query whose results overflow the table, autoscroll is enabled and then immediately disabled.
Code:
scrollTopdecreased and the user is not at the bottom of the table.Reviewer: