Conversation
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 8eb87da at 2026-10-02 23:22: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 8db4e50 at 2026-10-02 20:36: Full log here. |
shahor02
reviewed
Oct 2, 2026
Comment on lines
+259
to
+262
| if (TMath::Abs(mCalVdriftExB->getVdrift(det, true) - constants::VDRIFTDEFAULT) > 1e-6) { | ||
| driftVelocity = mCalVdriftExB->getVdrift(det, true) * constants::VDRIFTDEFAULT / mSimParam.getEffVdriftDefault(); // If they are available in the CCDB, we anchor the vdrift variations | ||
| } | ||
| float t0 = mCalib->getT0(det, colE, rowE); // The T0 velocity |
Collaborator
There was a problem hiding this comment.
It's good to access calib objects via standard DPL fetcher instead of locally instantiated BasicCCDBManager, but why not doing this for all objecs and getting rid of the mCalib entirely?
Comment on lines
+70
to
+71
| if (det >= constants::MAXCHAMBER) | ||
| return; |
Collaborator
There was a problem hiding this comment.
Statements w/o {} trigger code-checker failure.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anchoring of vdrift, lorentz angle, gain, chamber status