Skip to content

AFIT-81: Implementation of configurable parameters in FDD reco #15882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpierozak wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

AFIT-81: Implementation of configurable parameters in FDD reco #15882

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f853b73
Implemented FDD reconstruction parameters and modified reconstruction…
Jul 30, 2026
693e149
Renamed FDD reco param strucutre
Aug 13, 2026
9a6fc58
Updated LinkDef
Aug 14, 2026
1ba2f82
Please consider the following formatting changes
alibuild Aug 14, 2026
b726e54
Merge pull request #10 from alibuild/alibot-cleanup-15681
wpierozak Aug 14, 2026
474e4cd
Added copyright header to FDDRecoConfig.cxx
Aug 14, 2026
dc0203a
Added ClassDefNV statement to FDDRecoConfig struct
Aug 21, 2026
e5a6aad
Changed FDDRecoConfig::AmplitudeCutOnColiisionTimeWeight to float and…
Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Please consider the following formatting changes
  • Loading branch information
@alibuild
alibuild committed Aug 14, 2026
commit 1ba2f8272dceafe9f0c8c8e0cbf41d1894308529
10 changes: 5 additions & 5 deletions DataFormats/Detectors/FIT/FDD/include/DataFormatsFDD/FDDRecoConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@

#include "CommonUtils/ConfigurableParamHelper.h"

namespace o2::fdd {
struct FDDRecoConfig: o2::conf::ConfigurableParamHelper<FDDRecoConfig>
namespace o2::fdd
{
double AmplitudeCutOnCollisionTimeWeights = 3;
O2ParamDef(FDDRecoConfig, "FDDRecoConfig");
struct FDDRecoConfig : o2::conf::ConfigurableParamHelper<FDDRecoConfig> {
double AmplitudeCutOnCollisionTimeWeights = 3;

@sahilupadhyaya92 sahilupadhyaya92 Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"double" is used for "AmplitudeCutOnCollisionTimeWeights".
It is later compared with "adc" which is "Float_t adc = inChData[ich].mChargeADC;"
If no specific reason for the type change, then let's make it float ?

@wpierozak wpierozak Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine for me

O2ParamDef(FDDRecoConfig, "FDDRecoConfig");
};
}
} // namespace o2::fdd
#endif
2 changes: 1 addition & 1 deletion DataFormats/Detectors/FIT/FDD/src/FDDRecoConfig.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include<DataFormatsFDD/FDDRecoConfig.h>
#include <DataFormatsFDD/FDDRecoConfig.h>

using namespace o2::fdd;
O2ParamImpl(FDDRecoConfig);