Conversation
… parameters in BaseRecoTask
Co-authored-by: Felix Schlepper <f3sch.git@outlook.com>
| struct FV0RecoConfig : o2::conf::ConfigurableParamHelper<FV0RecoConfig> { | ||
| double AmplitudeLowerThreshold = 24; // only channels with amplitude higher will participate in calibration and collision time | ||
| double AmplitudeThreholdForMeanTime = 5; // Charge threshold, only above which the time is taken into account in calculating the mean time of all qualifying channels | ||
| double TimeUpperThershold = 1000.0; // only channels with time below will participate in calibration and collision time |
There was a problem hiding this comment.
Typo in "Threshold". Let's correct this so that the configurable parameter name is consistent.
| // or submit itself to any jurisdiction. | ||
|
|
||
| #ifndef ALICEO2_FV0_DIGIT_FILTER_PARAM | ||
| #define ALICEO2_FV0_DIGIT_FILTER_PARAM |
There was a problem hiding this comment.
The header was renamed to FV0RecoConfig.h, but the guard still refers to "FV0_DIGIT_FILTER_PARAM"
Could we rename it, for e.g. ALICEO2_FV0_RECO_CONFIG to avoid name clash ?
| struct FV0RecoConfig : o2::conf::ConfigurableParamHelper<FV0RecoConfig> { | ||
| double AmplitudeLowerThreshold = 24; // only channels with amplitude higher will participate in calibration and collision time | ||
| double AmplitudeThreholdForMeanTime = 5; // Charge threshold, only above which the time is taken into account in calculating the mean time of all qualifying channels | ||
| double TimeUpperThershold = 1000.0; // only channels with time below will participate in calibration and collision time |
There was a problem hiding this comment.
Also, any specific reason to change the type of the 3 parameters to double ?
Earlier it was:
float chargeThrForMeanTime = 5;
float mAmpThresholdForReco = 24;
short mTimeThresholdForReco = 1000;
There was a problem hiding this comment.
These parameters are compared with double members of ChannelDataFloat, so I changed them to double to avoid unnecessary casting for comparision
This branch has not been deployed
2 participants
Moved FV0 reconstruction parameters from digitizer configuration structure to dedicated configurable structure and updated reconstruction code to use it.
FV0RecoConfig inherits from ConfigurableParamHelper, so it can be modified by either command-line arguments or object fetched from CCDB.