Skip to content

TPC: several unrelated fixes and improvements #13079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wiechula merged 4 commits into from
Apr 26, 2024
Merged

TPC: several unrelated fixes and improvements #13079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e59d8c
Add calculation of mean values over all sectors
wiechula Apr 25, 2024
721b938
Add missing forward of template parameters, cleanup
wiechula Apr 25, 2024
54301c7
Add summary canvases from pad tree dump, cosmetic fixes
wiechula Apr 25, 2024
4e353ed
Possibility to load specific pedestal object for IDCs
wiechula Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing forward of template parameters, cleanup
  • Loading branch information
@wiechula
wiechula committed Apr 25, 2024
commit 721b93883ff563557d335baad4bdbe1ec69a9738
4 changes: 2 additions & 2 deletions Detectors/TPC/base/include/TPCBase/CRUCalibHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ int fillCalPad(CalDet<float>& calPad, gsl::span<const char> data)
membuf sbuf((char*)data.data(), data.size());
std::istream in(&sbuf);

return fillCalPad(calPad, in);
return fillCalPad<SignificantBitsT>(calPad, in);
}

/// create cal pad object from HW value file
Expand All @@ -237,7 +237,7 @@ o2::tpc::CalDet<float> getCalPad(const std::string_view fileName, const std::str
return calPad;
}

fillCalPad(calPad, infile);
fillCalPad<SignificantBitsT>(calPad, infile);

if (outputFile.size()) {
TFile f(outputFile.data(), "recreate");
Expand Down
1 change: 0 additions & 1 deletion Detectors/TPC/base/include/TPCBase/FEEConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include <unordered_map>
#include <vector>
#include <cstdint>
#include <numeric>

#include "Rtypes.h"

Expand Down