Fix: Handle invalid color formats and style errors gracefully - #5765
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
- Fix issue 2922: Catch ValueError in addition to ColorParseError when validating color settings - Fix issue 2962: Add fallback exception handling to all console print calls with styles to prevent MissingStyle crashes - Gracefully fall back to unstyled output when style application fails
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two related issues:
Fixes #2922
Uncaught exception when using --user-input-color with wrong format (e.g., missing # prefix like 'bcbdbf').
Fixes #2962
Uncaught MissingStyle error when choosing 'A' when prompted to add many files to the chat ('ansigray' style issue).
Changes Made
Improved color validation ():
Added style error fallback in all console output methods:
Testing