Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d4fe2efc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| jobs: | ||
| package: | ||
| if: github.event_name != 'release' || !startsWith(github.event.release.tag_name, 'ai-storyboard-director-v5.6.0-rc.') |
There was a problem hiding this comment.
For releases tagged ai-storyboard-director-v5.6.0-rc.*, this condition disables the repository's only release-triggered upload job. The new storyboard-preview.yml workflow has no release trigger and only runs tests and validation, and a repository-wide search finds no other builder for the promised preview ZIP or SHA256SUMS.txt; therefore publishing the documented prerelease leaves users without its downloadable package unless an undocumented manual build/upload happens.
Useful? React with 👍 / 👎.
| if path.is_symlink(): | ||
| errors.append({"code": "RUNTIME_SYMLINK_FORBIDDEN", "path": relative}) |
There was a problem hiding this comment.
When a manifest runtime file is a symlink, this check cannot detect it because path was already passed through .resolve() on line 114. Replacing the bundle's SKILL.md with an in-tree symlink still makes this validator return ready: true, so the explicit RUNTIME_SYMLINK_FORBIDDEN policy is bypassed and a manifest can omit the symlink's real dependency; retain the unresolved candidate for is_symlink() and resolve a separate path for containment and hashing.
Useful? React with 👍 / 👎.
| verify_source(root, proposed) | ||
| proposed["revision"] = old["revision"] + 1 | ||
| sha256 = save_state(root, proposed) |
There was a problem hiding this comment.
During an explicit amendment, a proposal can set source.path to .director_design/state.json with the current state's hash and line count, and this verification succeeds. The subsequent save overwrites that same file with the amended state, so the command reports success but every following context, ordinary commit, or export immediately fails with SOURCE_DRIFT; reject the state file, or the reserved .director_design tree, as a script source before committing.
Useful? React with 👍 / 👎.
| reviews = validate_state(state) | ||
| if args.allow_unverified_geometry: | ||
| text_field(args.review_note, "--review-note") | ||
| else: | ||
| require(not args.review_note, "REVIEW_FLAG_REQUIRED", "--review-note requires --allow-unverified-geometry") | ||
| require(not reviews, "NEEDS_GEOMETRY_REVIEW", "Design retained; review geometry or explicitly export an unverified candidate") |
There was a problem hiding this comment.
When any unrelated scene has axis.status: needs_geometry_review, validate_state(state) adds it to this global reviews list, so exporting a fully checked scene named by --scene is rejected as NEEDS_GEOMETRY_REVIEW; using the override instead incorrectly labels that checked scene's receipt as an unverified candidate. This makes one unfinished scene block delivery of every completed scene in a long project, so retain whole-state structural validation but apply the geometry-review export gate to the selected scene.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Outcome
Describe the user-visible result this change produces.
Scope
Evidence
python scripts/validate_repository.pypassesRisk and rollback
Describe compatibility risks and the smallest safe rollback.